zcash / pasta_curves

Rust implementation for zcash/pasta
Other
80 stars 49 forks source link

Implement serde for Ep, Eq #53

Closed samuelburnham closed 1 year ago

samuelburnham commented 1 year ago

Converts to affine before serializing, as recommended by https://github.com/zcash/pasta_curves/pull/36#pullrequestreview-962731013

codecov-commenter commented 1 year ago

Codecov Report

Base: 67.32% // Head: 67.69% // Increases project coverage by +0.36% :tada:

Coverage data is based on head (5e7d16b) compared to base (f8ba48d). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #53 +/- ## ========================================== + Coverage 67.32% 67.69% +0.36% ========================================== Files 11 11 Lines 1261 1269 +8 ========================================== + Hits 849 859 +10 + Misses 412 410 -2 ``` | [Impacted Files](https://codecov.io/gh/zcash/pasta_curves/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash) | Coverage Δ | | |---|---|---| | [src/serde\_impl.rs](https://codecov.io/gh/zcash/pasta_curves/pull/53/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL3NlcmRlX2ltcGwucnM=) | `83.33% <100.00%> (+3.33%)` | :arrow_up: | | [src/curves.rs](https://codecov.io/gh/zcash/pasta_curves/pull/53/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2N1cnZlcy5ycw==) | `54.89% <0.00%> (+0.51%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.