search

zcash / pasta_curves

Rust implementation for zcash/pasta
Other
80 stars 49 forks source link

Trait cleanups ahead of `FieldExt` removal #54

Closed str4d closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Base: 68.89% // Head: 70.28% // Increases project coverage by +1.39% :tada:

Coverage data is based on head (4fe909f) compared to base (1bd803d). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #54 +/- ## ========================================== + Coverage 68.89% 70.28% +1.39% ========================================== Files 11 11 Lines 1212 1188 -24 ========================================== Hits 835 835 + Misses 377 353 -24 ``` | [Impacted Files](https://codecov.io/gh/zcash/pasta_curves/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash) | Coverage Δ | | |---|---|---| | [src/arithmetic/fields.rs](https://codecov.io/gh/zcash/pasta_curves/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2FyaXRobWV0aWMvZmllbGRzLnJz) | `93.90% <ø> (ø)` | | | [src/curves.rs](https://codecov.io/gh/zcash/pasta_curves/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2N1cnZlcy5ycw==) | `55.75% <ø> (+0.86%)` | :arrow_up: | | [src/fields/fp.rs](https://codecov.io/gh/zcash/pasta_curves/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2ZpZWxkcy9mcC5ycw==) | `81.91% <ø> (+2.63%)` | :arrow_up: | | [src/fields/fq.rs](https://codecov.io/gh/zcash/pasta_curves/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2ZpZWxkcy9mcS5ycw==) | `81.18% <ø> (+2.60%)` | :arrow_up: | | [src/hashtocurve.rs](https://codecov.io/gh/zcash/pasta_curves/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2hhc2h0b2N1cnZlLnJz) | `70.14% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

str4d commented 1 year ago

Closing because I need to modify the contents of this PR, and I now have a better one coming 😈