search

zcash / pasta_curves

Rust implementation for zcash/pasta
Other
80 stars 49 forks source link

Remove `FieldExt` and `Group` traits #55

Closed str4d closed 1 year ago

str4d commented 1 year ago 
One, two! One, two! And through and through
    The vorpal blade went snicker-snack!
He left it dead, and with its head
    He went galumphing back.

Depends on https://github.com/zkcrypto/ff/pull/98. Closes zcash/pasta_curves#42.

codecov-commenter commented 1 year ago

Codecov Report

Base: 68.89% // Head: 70.64% // Increases project coverage by +1.74% :tada:

Coverage data is based on head (825cb94) compared to base (1bd803d). Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #55 +/- ## ========================================== + Coverage 68.89% 70.64% +1.74% ========================================== Files 11 11 Lines 1212 1182 -30 ========================================== Hits 835 835 + Misses 377 347 -30 ``` | [Impacted Files](https://codecov.io/gh/zcash/pasta_curves/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash) | Coverage Δ | | |---|---|---| | [src/arithmetic/curves.rs](https://codecov.io/gh/zcash/pasta_curves/pull/55/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2FyaXRobWV0aWMvY3VydmVzLnJz) | `0.00% <ø> (ø)` | | | [src/arithmetic/fields.rs](https://codecov.io/gh/zcash/pasta_curves/pull/55/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2FyaXRobWV0aWMvZmllbGRzLnJz) | `93.90% <ø> (ø)` | | | [src/curves.rs](https://codecov.io/gh/zcash/pasta_curves/pull/55/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2N1cnZlcy5ycw==) | `56.05% <ø> (+1.15%)` | :arrow_up: | | [src/lib.rs](https://codecov.io/gh/zcash/pasta_curves/pull/55/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2xpYi5ycw==) | `0.00% <ø> (ø)` | | | [src/fields/fp.rs](https://codecov.io/gh/zcash/pasta_curves/pull/55/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2ZpZWxkcy9mcC5ycw==) | `82.52% <33.33%> (+3.24%)` | :arrow_up: | | [src/fields/fq.rs](https://codecov.io/gh/zcash/pasta_curves/pull/55/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2ZpZWxkcy9mcS5ycw==) | `81.78% <33.33%> (+3.21%)` | :arrow_up: | | [src/hashtocurve.rs](https://codecov.io/gh/zcash/pasta_curves/pull/55/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2hhc2h0b2N1cnZlLnJz) | `70.14% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.