zcash / pasta_curves

Rust implementation for zcash/pasta
Other
81 stars 49 forks source link

Improve 64-bit to 32-bit limb conversion #56

Closed vmx closed 2 years ago

vmx commented 2 years ago

The code base is now on Rust 1.56 and Rust edition 2021. As per https://github.com/zcash/pasta_curves/pull/31#discussion_r824826344 the code can now be simplified. This commit is also adding a test for the u64_to_u32 function.

I've based it on main, but I'll happily rebase once other PRs are merged first.

codecov-commenter commented 2 years ago

Codecov Report

Base: 68.89% // Head: 69.25% // Increases project coverage by +0.36% :tada:

Coverage data is based on head (67e5595) compared to base (1bd803d). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #56 +/- ## ========================================== + Coverage 68.89% 69.25% +0.36% ========================================== Files 11 11 Lines 1212 1210 -2 ========================================== + Hits 835 838 +3 + Misses 377 372 -5 ``` | [Impacted Files](https://codecov.io/gh/zcash/pasta_curves/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash) | Coverage Δ | | |---|---|---| | [src/fields.rs](https://codecov.io/gh/zcash/pasta_curves/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2ZpZWxkcy5ycw==) | `100.00% <100.00%> (+100.00%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.