search

zcash / sapling-crypto

Zcash "Sapling" cryptography
Other
78 stars 65 forks source link

Explicitly define `edwards_a`? #103

Open arielgabizon opened 4 years ago

arielgabizon commented 4 years ago

https://github.com/zcash-hackworks/sapling-crypto/blob/b70d6e66fc1de66f8609e22a2b13eb11bdeb69b3/src/jubjub/mod.rs#L104

Right now it seems the code implicitly uses a=-1 which assumes -1 is QR if Fr. Might be better to make this explicit.