search

zcash / sapling-crypto

Zcash "Sapling" cryptography
Other
80 stars 67 forks source link

Stale comments about bit order in circuit/sapling/mod.rs #88

Open daira opened 6 years ago

daira commented 6 years ago

https://github.com/zcash-hackworks/sapling-crypto/blob/21084bde2019c04bd34208e63c3560fe2c02fb0e/src/circuit/sapling/mod.rs#L467-L468

It is actually little-endian, as implemented in https://github.com/zcash-hackworks/sapling-crypto/blob/21084bde2019c04bd34208e63c3560fe2c02fb0e/src/circuit/sapling/mod.rs#L89-L93

daira commented 6 years ago

There's another one here: https://github.com/zcash-hackworks/sapling-crypto/blob/21084bde2019c04bd34208e63c3560fe2c02fb0e/src/circuit/sapling/mod.rs#L264-L265