search

zcash / zcash

Zcash - Internet Money
https://z.cash/
Other
4.94k stars 2.04k forks source link

Delete old version constants from src/version.h, and make code that used them unconditional #2244

Open daira opened 7 years ago

daira commented 7 years ago

The Zcash network launched with a PROTOCOL_VERSION of 170002. This is also the value of MIN_PEER_PROTO_VERSION, so we will immediately disconnect from any peer claiming to have an older version than this. However version.h also defines several constants for older Bitcoin P2P protocol versions that lacked various features or that needed workarounds for bugs. We should remove these, and simplify any code that references them to assume that the features are available, and that the workarounds are not needed.

daira commented 7 years ago

Reopening because the PR was reverted (due to an incompatibility in serialization of the "version" message).