search

zcash / zips

Zcash Improvement Proposals
https://zips.z.cash
MIT License
273 stars 156 forks source link

generator of G1 and G2 in 5.4.8.1 and 5.4.8.2 is the same (between BN254 and BLS12-381) #205

Closed zhanglei486 closed 5 years ago

zhanglei486 commented 5 years ago

generator of G1 and G2 in section 5.4.8.1 and section 5.4.8.2 is the same, I have checked generator of G1 and G2 in section 5.4.8.2 is error. generators from https://github.com/zkcrypto/pairing/tree/e72660056e00c93d6b054dfb08ff34a1c67cb799/src/bls12_381

G1

x = 3685416753713387016781088315183077757961620795782546409894578378688607592378376318836054947676345821548104185464507
y = 1339506544944476473020471379941921221584933875938349620426543736416511423956333506472724655353366534992391756441569

G2


x = 3059144344244213709971259814753781636986470325476647558659373206291635324768958432433509563104347017837885763365758*u + 352701069587466618187139116011060144890029952792775240219908644239793785735715026873347600343865175952761926303160
y = 927553665492332455747201965776037880757740193453592970025027978793976877002675564980949289727957565575433344219582*u + 1985150602287291935568054521177171638300868978215655730859378665066344726373823718423869104263333984641494340347905
daira commented 5 years ago

Thankyou, that's definitely a copy-and-paste error in the spec.

daira commented 5 years ago

This was fixed in 2019.0-beta-38.