search

zcaudate-me / lein-repack

moved -> 'lucid.distribute'
65 stars 5 forks source link

Leave source-paths in the project.clj so classpath roots are preserved properly. #13

Closed RickMoynihan closed 9 years ago

RickMoynihan commented 9 years ago

This fix preserves the :source-path in the project.clj file in the repacked dependencies.

The reason I think this is useful is that repack currently doesn't afford much control over the number of dependencies that are generated. i.e. it will generate packages for namespaces that don't really make much sense for a user to depend on alone.

I'd like a more curated set on grafter ( http://grafter.org/ ) which is why I have the different top level packages specified in my src tree. Having direct control over this via the project.clj file would be ideal, as the approach of creating subfolders in src/ feels a bit hacky.

Regardless I thought I'd send you a PR on the off chance its useful... but I suspect the feature might be implemented in a nicer manner.

zcaudate commented 9 years ago

Yep I see the change and it is the right fix. I forgot to remove that line after v0.2. I'll update the code accordingly.

Thanks for picking that up!

On 7 Feb 2015, at 12:49, Rick Moynihan notifications@github.com wrote:

This fix preserves the :source-path in the project.clj file in the repacked dependencies.

The reason I think this is useful is that repack currently doesn't afford much control over the number of dependencies that are generated. i.e. it will generate packages for namespaces that don't really make much sense for a user to depend on alone.

I'd like a more curated set on grafter ( http://grafter.org/ ) which is why I have the different top level packages specified in my src tree. Having direct control over this via the project.clj file would be ideal, as the approach of creating subfolders in src/ feels a bit hacky.

Regardless I thought I'd send you a PR on the off chance its useful... but I suspect the feature might be implemented in a nicer manner.

You can view, comment on, or merge this pull request online at:

https://github.com/zcaudate/lein-repack/pull/13

Commit Summary

Fix so repacked projects include :source-paths to ensure namespaces are Update commented out code to reflect new function names change clojars group name so we can deploy temporary fork. File Changes

M project.clj (2) M src/leiningen/repack/split.clj (5) M src/leiningen/repack/split/rewrite.clj (2) Patch Links:

https://github.com/zcaudate/lein-repack/pull/13.patch https://github.com/zcaudate/lein-repack/pull/13.diff — Reply to this email directly or view it on GitHub.

zcaudate commented 9 years ago

I've updated the changes in 0.2.9 version of repack.