Closed RyanMcG closed 9 years ago
Thanks Ryan for picking this up. I've only been working with the slash version if the projects so there is a case missing. Yes, a PR would be most welcomed. I can add you to the project if you like.
On 15 Dec 2014, at 11:26, Ryan McGowan notifications@github.com wrote:
If the project name is blarg, then the group id is blarg and the artifcat id is blarg. It seems that parts of repack thinks the blarg.foo library has the group id of blarg.foo and other parts think it is blarg (compiled assets use blarg.foo but generated project.cljs think it is blarg).
Modifying project.clj so that the project name is blarg/blarg instead of blarg fixes the issue.
I can probably submit a PR for this but I need to get approval first.
— Reply to this email directly or view it on GitHub.
Thanks for adding me! I'm going to get you to review any PRs I post anyway though.
I can probably submit a PR for this but I need to get approval first.
Perhaps I should have been more clear, but the approval I have yet to acquire is from my job. I wasn't asking for push permissions. I'm not sure if that's what you thought or not, but just an FYI, they might say no (although that seems unlikely).
I got approval. I'll be working on this soon.
Great news! thanks for your help!
This has been fixed
If the project name is
blarg
, then the group id isblarg
and the artifcat id isblarg
. It seems that parts of repack thinks theblarg.foo
library has the group id ofblarg.foo
and other parts think it isblarg
(compiled assets useblarg.foo
but generatedproject.clj
s think it isblarg
).Modifying
project.clj
so that the project name isblarg/blarg
instead ofblarg
fixes the issue.I can probably submit a PR for this but I need to get approval first.