Instructor Feedback - Week 11

[pawaitemadisoncollege]

@zcmarcus @kpalese @sschmitt2 It looks like you have made some great progress on your team project and I can't wait to see the demo next week!

I know you are still actively working on this, and have work going on in other branches, so these items may already be on your radar (I only reviewed master):

• [ ] Add a link on readme.md to your deployed service (and user documentation if that is in a different location).
• [ ] Does it make sense to put hard-coded values like https://github.com/zcmarcus/Slack2Slack/blob/ecf33ee7136793024a074c2243285dac47be78bd/src/main/java/com/slack2slack/api/SlackApi.java#L45 in a properties file for easier maintenance?
• [ ] What happens if the db connection fails or call to Slack's api fails? Is the response still 200?
• [ ] What kind of assertion can be made to verify this worked? https://github.com/zcmarcus/Slack2Slack/blob/ecf33ee7136793024a074c2243285dac47be78bd/src/test/java/com/slack2slack/api/SlackApiTest.java#L13-L14