search

zcreativelabs / react-simple-maps

Beautiful React SVG maps with d3-geo and topojson using a declarative api.
https://www.react-simple-maps.io/
MIT License
3.03k stars 424 forks source link

Additional React ~18 support #287

Closed zeromero-dev closed 1 year ago

zeromero-dev commented 1 year ago

I tried to update the dependencies in package.json and package-lock.json to add the support for React v.18, but I can't see how I can actually test and run the project to see if any bug occurs.

It would be great if you could provide me with a guide on how to run the project to see if everything works as it should. All the tests and builds were performed.

zimrick commented 1 year ago

Hi @zeromero-dev, Thank you for trying this out. I deployed a new beta earlier today with react 18 support. You can try it out npm install react-simple-maps@beta. There's still some more stuff in the works, but this will be part of react-simple-maps v3.

zeromero-dev commented 1 year ago

That's great news! So my pull request is no longer needed, right? If not, I'd be glad to help you @zimrick out.

zimrick commented 1 year ago

Yeah, it's ok. I merged your previous one for the peer dependencies. That should be ok for now. We are currently working on a number of things here in order to make this repo a bit easier to test and contribute to.