search

zcreativelabs / react-simple-maps

Beautiful React SVG maps with d3-geo and topojson using a declarative api.
https://www.react-simple-maps.io/
MIT License
3.12k stars 426 forks source link

Types are not compatible with the React 18 types #347

Closed lukask-proxora closed 1 year ago

lukask-proxora commented 1 year ago

In this PR in DefinitelyTyped for the React 18 type, the implicit children prop for React components was removed.

This leads to an incompatibility of the react-simple-maps types with the React 18 types.

I created a PR to fix this: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/67195

However, the maintainers of the react-simple-maps module in the DefinitelyTyped repository do not seem to react to my PR.

lukask-proxora commented 1 year ago

Closing this issue, since the PR got approved.

Thanks for helping! 👍