Remove emit prop - Githubissues

zcuric / plyrue

Vue.js plugin for Plyr.io

MIT License

31 stars 6 forks source link

Remove emit prop #11

Closed MiroDojkic closed 4 years ago

MiroDojkic commented 4 years ago

This PR:

Simplifies component API by removing emit prop

Changes:

[x] removes redundant emit prop and instead attaches handlers to plyr's events through $listeners instance property
[x] updates component event usage examples and removes documentation about emit prop in the README
[x] updates test for event emission by testing against handler being called

zcuric commented 4 years ago

👍 Very nice!