zd1 / telseq

A software for calculating telomere length
GNU General Public License v3.0
66 stars 26 forks source link

Secondary and supplementary reads #30

Open lindenb opened 4 years ago

lindenb commented 4 years ago

Hi, unless I'm wrong, supplementary and seconday alignments are not ignored in your code.

https://github.com/zd1/telseq/blob/master/src/Telseq/telseq.cpp#L275

shouldn't you remove them ?

Furthermore, speed could be improved by using references instead of values:

e.g:

int countMotif(std::string &read, std::string& pattern, std::string& pattern_revcomp){

instead of

int countMotif(std::string &read, std::string pattern, std::string pattern_revcomp){