search

zdavatz / AmiKo-iOS

AmiKo Desitin für iPhone und iPad
https://apps.apple.com/ch/app/amiko-desitin/id687642725
GNU General Public License v3.0
1 stars 2 forks source link

Implement Dark Mode for iOS 13 #101

Closed zdavatz closed 5 years ago

zdavatz commented 5 years ago
bettar commented 5 years ago

Interesting article https://www.fivestars.blog/code/ios-dark-mode-how-to.html

zdavatz commented 5 years ago

Kinda very cool: https://developer.apple.com/design/downloads/SF-Symbols.dmg

zdavatz commented 5 years ago

Thin

Bildschirmfoto 2019-08-27 um 11 22 00

Richtext Star Exclamation Note Chevron

bettar commented 5 years ago

on a related note, the project is now including "IonIcons", in particular the file ionicons.tff, but it's not clear whether that's actually used or not.

zdavatz commented 5 years ago

Can you remove it?

bettar commented 5 years ago

what are the names of each icon that you are showing ?

zdavatz commented 5 years ago

the order is the same.

zdavatz commented 5 years ago

https://developer.apple.com/design/human-interface-guidelines/ios/icons-and-images/custom-icons/

zdavatz commented 5 years ago

https://link.medium.com/EzzwzZPQuZ

zdavatz commented 5 years ago

https://www.vtourraine.net/blog/2019/wwdc-2019-sf-symbols

bettar commented 5 years ago

What are these three dots?

Bildschirmfoto 2019-08-29 um 08 18 43

Maybe they have always been there, but for some devices they are hidden under the search bar. For example iPhone 8 shows the search bar extending all the way to the right and covering them, for iPhone XR and iPhone 8 Plus the screen is 39 pixels wider, therefore the search bar appears narrower and the three dots are visible. I think the version currently published has the same problem, but the dots being white on a light-grey background don't stand out so much (confirmed with the simulator): Screenshot 2019-08-29 at 09 32 10

The ellipsis (3 dots) is actually indicating that the "title" is being cutoff. By temporarily making the search bar narrower we can appreciate that. Screenshot 2019-08-30 at 18 29 28

The title is displayed on its own bar only for the iPad anyway, so to fix it for the iPhone the title should not be set.

zdavatz commented 5 years ago
  1. Camera is not a square yet https://github.com/zdavatz/AmiKo-iOS/issues/101#issuecomment-525630487
  2. Prescription history has white top and bottom https://github.com/zdavatz/AmiKo-iOS/issues/101#issuecomment-526048693
  3. Make searchbar wider https://github.com/zdavatz/AmiKo-iOS/issues/101#issuecomment-526041626
  4. In-Text Search is not cleared and the index of the In-Text Search is wrong if nothing is found: https://github.com/zdavatz/AmiKo-iOS/issues/101#issuecomment-526041994