zdavatz / AmiKo-iOS

AmiKo Desitin für iPhone und iPad
https://apps.apple.com/ch/app/amiko-desitin/id687642725
GNU General Public License v3.0
1 stars 2 forks source link

Cancel Update ignored #108

Closed bettar closed 4 years ago

bettar commented 5 years ago

Steps to reproduce: Pill menu, Update, then after a few seconds of download tap "Cancel"

Problem: the update still seems to go through and the Cancel is ignored, at least that's what the pop up message says at the end.

Interesting to note that the Android version of the App doesn't have the Cancel button.

zdavatz commented 5 years ago

How about we just remove the cancel button?

zdavatz commented 5 years ago

Or we could fix the Cancel Button.

bettar commented 4 years ago

So which way is it , remove or fix ? If you want to fix it, what is the intended behaviour ? should the Cancel abort only the current download or all pending downloads ?

zdavatz commented 4 years ago

what is the difference between "pending" and "current"?

bettar commented 4 years ago

For each update there are 4 files to be downloaded. For example one has been completely downloaded, the second one is half way through when we tap Cancel. This this the "current" one. The remaining two in the queue are the "pending" ones

zdavatz commented 4 years ago

"Cancel" removes all files also the ones that have already been downloaded, and also the partially downloaded ones.

zdavatz commented 4 years ago
  1. Remove cancel button.
  2. Show progress bar for frequency and full_db file.