search

zdavatz / AmiKo-iOS

AmiKo Desitin für iPhone und iPad
https://apps.apple.com/ch/app/amiko-desitin/id687642725
GNU General Public License v3.0
1 stars 2 forks source link

Make doctor view swipeable. #3

Closed zdavatz closed 6 years ago

zdavatz commented 6 years ago

Whenever there is am "Hamburger" the view should be swipeable.

bettar commented 6 years ago

This is not straightforward to debug and fix, because it seems to work in the simulator.

zdavatz commented 6 years ago

The doctor view is not swipeable in the simulator.

bettar commented 6 years ago

I just verified it: it is swipeable in the simulator when you run it from my fork of the project, but not from your original project

zdavatz commented 6 years ago

How do you swipe?

zdavatz commented 6 years ago

Where do you place the mouse in the doctor view when you pull to the right?

bettar commented 6 years ago

I start dragging from near the left edge. It doesn't seem to be critical the exact spot.

zdavatz commented 6 years ago

Where? Below the fields (below the Selfie) or at which field name?

bettar commented 6 years ago

For example, I start dragging with the mouse exactly from the "Z" of the ZIP label.

zdavatz commented 6 years ago

Ok, that does not happen in my simulator. Can you test with an iPhone attached to the iMac?

zdavatz commented 6 years ago

https://stackoverflow.com/questions/3648967/how-to-recognize-swipe-gesture-in-uiscrollview/3652999

bettar commented 6 years ago

On the real device it doesn't work, as you reported. That's why I said it's not straightforward to debug. Maybe the ScrollViews are intercepting the gesture.

bettar commented 6 years ago

Disabling the scroll action as suggested in the link you posted seems to have fixed it !

bettar commented 6 years ago

The problem is with the patient view now. If we make it non scrollable there is no way of getting to the fields at the bottom. I wonder why with the simulator you can have both things.

bettar commented 6 years ago

I think I found the proper way of fixing this: rather that disabling the "scroll" action we need to disable the "bounce" action.

zdavatz commented 6 years ago

Yes, agreed.

zdavatz commented 6 years ago

https://stackoverflow.com/questions/500761/stop-uiwebview-from-bouncing-vertically

zdavatz commented 6 years ago

We need a Full-Screen-Content page that is scrollable and swipeable and does not bounce. https://developer.apple.com/documentation/uikit/uipageviewcontroller?language=objc

zdavatz commented 6 years ago

This has been fixed with commit ac77890e0e341d370