zdavatz / amiko-osx

AmiKo Desitin for AmiKo OS X
https://apps.apple.com/ch/app/amiko-desitin/id708142753?mt=12
GNU General Public License v3.0
3 stars 2 forks source link

Dead links #87

Closed bettar closed 4 years ago

bettar commented 4 years ago

The search results for all 6 types (Pra, Inh, Wir, Zul, The, Vol) in all 4 views (Kom, Fav, Int, Rez) are presented with a title (larger font, the same for all 6 types) and a list of 1 or more entries giving details that is different for each search type. Each detail item appears as clickable, but for 4 of the 6 search types it doesn't appear to do anything ?

Is this intentional, to have dead links for 4 of the 6 search results ?

zdavatz commented 4 years ago

Screenshot please.

bettar commented 4 years ago

Screenshot 2020-07-27 at 11 24 36 Just an example, the arrow shows a link that does nothing

zdavatz commented 4 years ago

no, this is not intentional. They can be disabled.

bettar commented 4 years ago

In other words, for 4 of the 6 search types they could be displayed as a plain list, without clickable appearance ?

zdavatz commented 4 years ago

In other words, for 4 of the 6 search types they could be displayed as a plain list, without clickable appearance ?

Yes, we only need the clickable links for adding packages to the prescription or for selecting ATC-Codes (longtap on Android and iOS), see: https://github.com/zdavatz/amiko-web/issues/26

bettar commented 4 years ago

Selecting ATC-Codes ? Lets's not add to the confusion my talking about iOS and Android. What should clicking the link do in amiko-osx ?

zdavatz commented 4 years ago

Clicking the ATC-Code currently only works for AmiKo-Web, iOS and Android.

bettar commented 4 years ago

So in which cases the links work in amiko-osx ? Pra and Vol ?

zdavatz commented 4 years ago

Only for Präparat, adding a package to a prescription.

bettar commented 4 years ago

Now they appear as links also in the Full Text results (VOL). Are you saying that this is a bug ?

zdavatz commented 4 years ago

It is not a bug. The implementation was just never finished, to disable the links, after we added the selection of the packages for the prescription.

bettar commented 4 years ago

To me it looks like it's working fine and at least that part is completed. In summary the sub-items listed as search results are clickable for 2 search types Pra and Vol. The other 4 search results should present the results as plain list, not clickable list. Correct ?

zdavatz commented 4 years ago

correct.

bettar commented 4 years ago

Maybe here we could start a new issue, but consider the following:

we ascertained that

Consequently the following combinations are useless because any clicking produces no effect:

Question: should they be disabled or greyed out somehow ?

zdavatz commented 4 years ago

they should be not clickable.

bettar commented 4 years ago

What are you referring to with "they" the tiles or the items in the list ?

zdavatz commented 4 years ago

Clicking for example on the company should create a new search for all products of that company.

bettar commented 4 years ago

2 hours ago we reached the consensus that "The other 4 search results should present the results as plain list, not clickable list". Has this changed again ?

zdavatz commented 4 years ago

In any cell you can click on the star (favorite), the title and an item of the list.

Clicking on the title in Preparations view shows the Fachinfo. Clicking on the title in interactions view adds Title/ATC-Code to the basket. See image 7.

Generally speaking view order is Compendium, Interactions, Prescription. For Favorites the same logic applies like for the Compendium view, but only for the favorites.

Clicking on the title in the prescription view adds all packages of that Fachinfo to the prescription. For FTS it adds all packages of all brand names in the FTS result.

For interactions the packages are not relevant because the ATC code is based on the brand-name.

  1. Clicking on the Brandname in the Compendium view shows the Fachinfo. ✅ 1.1 The package view makes no sense in the interactions tab as the interactions are based on Title/ATC-Code. ✅ 1.2 Clicking on a Package (list) in the prescription view gives the options to add the package to the prescription. ✅
  2. Clicking on a company link in the Compendium view should show all products of that company. https://github.com/zdavatz/amiko-osx/issues/90 2.1 For the interactions view it will add the Title/ATC-Code (see image 7) into the interactions basket. #101 2.2. For the prescription view it will add all packages for that company to the prescription. #101
  3. Clicking on a ATC-Code link in the Compendium view should show all products with the same ATC-Code. https://github.com/zdavatz/amiko-osx/issues/89 3.1 For the interactions view it will add the Title/ATC-Code (see image 7) into the interactions basket. #102 3.2 For the prescription view it will add all packages for that ATC-Code to the prescription. #102
  4. Clicking on a registration number link in the compendium view in the list should do nothing. 4.1 For the interactions view clicking on a registration number link in the list should do nothing. 4.2 For the prescription view clicking on a registration number link in the list should do nothing.
  5. Clicking on a Therapy link in the Compendium view should add the same word to the search bar and then reload the search result. #106 5.1 For the interactions view it should add Title/ATC-Code (see image 7) into the interaction basket. #106 5.2 For the Prescritption view it should add all packages for that therapy to the prescription. #106
  6. In the Compedium view for FTS the links in the list view should be disabled or go to the same place like clicking on the search term. 6.1 For FTS interaction view it should add Title/ATC-Code to the interaction basket. 6.2 For the Prescription view it should add all packages of the FTS search to the prescription.

Image for 2:

Bildschirmfoto 2020-07-27 um 19 38 33

Image for 5.1:

Bildschirmfoto 2020-07-27 um 19 24 59

Image 6:

Bildschirmfoto 2020-07-27 um 19 27 37

Image 7:

Bildschirmfoto 2020-07-27 um 20 15 10