search

zdavatz / amiko_wx

AmiKo/CoMed for Linux and macOS done with wxwidgets and C++, 64 bit. Starts from macOS 10.9
GNU General Public License v3.0
2 stars 1 forks source link

In-Text-Search is not working on macOS Version #132

Closed zdavatz closed 3 years ago

zdavatz commented 3 years ago
  1. Start macOS App.
  2. Search for "Ponstan".
  3. Select "Ponstan".
  4. Search for any word in the Fachinfo of "Ponstan".
  5. Highlighting and Search for the word is not working. Note: Works well on the Linux version.
b123400 commented 3 years ago

https://github.com/zdavatz/amiko_wx/blob/a6d079f00de33fdf66ee276ace624a9cc5b0307c/gui/MainWindow.cpp#L2725 As Alex wrote here, it is not supported on Mac yet.

The official documentation says:

This always returns wxNOT_FOUND on the macOS WebKit backend. https://docs.wxwidgets.org/trunk/classwx_web_view.html#a75b8b033d2a1a45f8c491c3da2c96312

So this is not a bug, and if it has to be implemented, we probably need to use Javascript and inject into the webview, similar to Amiko-Android's way.

zdavatz commented 3 years ago

ok, good to know. Lets implement it.