search

zdavatz / oddb2xml

oddb2xml, create xml files using refdata, swissmedic and bag xml files
http://www.ywesee.com/Oddb2xml/Index
GNU General Public License v3.0
8 stars 5 forks source link

add option `--firstbase` or `--fb` to build all NONPHARMA articles on firstbase. #63

Closed zdavatz closed 11 months ago

zdavatz commented 1 year ago
  1. add option --firstbase or --fb to build all NONPHARMA articles on firstbase.
  2. Running oddb2xml with the option --fb should build all NONPHARMA products on firstbase.
  3. Fill up missing prices from transfer.dat when --firstbase option is used.
  4. Using --firstbase option, all PHARMA articles have reduced VAT and all NONPHARMA articles have standard VAT.
  5. https://www.firstbase.ch/sites/default/files/2023-09/firstbase_healthcare_public_data-dump%2C%2020230920.xlsx
ngiger commented 1 year ago

Does not look to be very difficult to implement, but the resulting files will be VERY different, as the old Zur Rose Transfer.dat contained over 160'000 lines and we find only 90'000 lines in the new XLSX. Therefore I would suggest to open a separate Branch for this feature and ask the different consumers to see whether the resulting output files still serve their needs. Eg. for Elexis it could well be that some of medical cabinets are using articles not (yet) in firstbase.xlsx. And how can they report missing articles back? Via Medelexis?

ngiger commented 11 months ago

I do not like the file name with a date stamp in it. I would prefer (may be via a link) to fetch https://www.firstbase.ch/sites/default/files/firstbase_healthcare_public_data-dump_latest.xlsx instead of https://www.firstbase.ch/sites/default/files/2023-09/firstbase_healthcare_public_data-dump%2C%2020230920.xlsx Any chance that firstbase could change this soon?

ngiger commented 11 months ago

Removed Ruby 2.6 from supported versions. Is this problem for some downstream users?

https://www.ruby-lang.org/en/downloads/branches/ says about Ruby 2.6

Ruby 2.6

status: eol
release date: 2018-12-25
normal maintenance until: 2021-04-01
EOL: 2022-04-12

Build failed with this error message:

Fetching gem metadata from https://rubygems.org/........
ox-2.14.17 requires ruby version >= 2.7.0, which is incompatible with the
current version, 2.6.10
Error: The process '/opt/hostedtoolcache/Ruby/2.6.10/x64/bin/bundle' failed with exit code 5
ngiger commented 11 months ago

Option name will be "-b" or "--firstbase" withan help text of " -b, --firstbase build all NONPHARMA articles on firstbase"

zdavatz commented 11 months ago

you can remove Ruby 2.6.0, no probelm.