Fixes remaining spec warnings and updates gemspec

zdavatz / spreadsheet

The Ruby Spreadsheet by ywesee GmbH

http://spreadsheet.ch

GNU General Public License v3.0

1.13k stars 240 forks source link

Fixes remaining spec warnings and updates gemspec #227

Closed weilandia closed 5 years ago

weilandia commented 5 years ago

Bumps gems
Fixes remaining warnings in specs (see also https://github.com/zdavatz/spreadsheet/pull/226)

Before:

After:

[fixes-remaining-spec-warnings-and-updates-gemspec]

zdavatz commented 5 years ago

Again, all tests are failing, except for Ruby 2.3.3. When you submit patches you have to make sure, that all tests pass. See below, continuous Travis integration.

weilandia commented 5 years ago

@zdavatz all the tests are failing because the bundler version is not pegged on Travis, and the new version no longer supports ruby < 2.3.0.

weilandia commented 5 years ago

I can specify the bundler version for Travis, but that seems out of the scope of my prs -- Any pr that doesn't do this would currently fail travis.

zdavatz commented 5 years ago

thank you, I will merge this asap.