zdavatz / spreadsheet

The Ruby Spreadsheet by ywesee GmbH
http://spreadsheet.ch
GNU General Public License v3.0
1.13k stars 240 forks source link

fixed unit test errors caused by frozen string literal #232

Closed taichi-ishitani closed 5 years ago

taichi-ishitani commented 5 years ago

Hi,

I fixed unit test errors caused by frozen string literal. af6206e

To test above changes on CI regression, I also changed files below too:

If you don't want to introduce changes of Gemfile, Gemfile.lock and .travis.yml to master repository, please ignore commits 75caf13 and ec10f8b.

zdavatz commented 5 years ago

Aligatoo!

taichi-ishitani commented 5 years ago

Hi @zdavatz ,

Thank you for merging my PR ! BTW, there're something I have to tell you:

  1. I disabled e-mail notification from Travis CI temporally. If you want to get e-mail notification, you need to edit .travis.yml and revert lines bellow.
  2. You should edit Gemfile and revert ruby-ole dependency when my PR (aquasync/ruby-ole#24) is merged and the ruby-ole gem including my PR is released. In addition you also need to edit .travis.yml and delete USE_LATEST_RUBY_OLE=yes environment variable.
zdavatz commented 5 years ago
  1. I do not care about the Email notifications.
  2. Can you please send me a pull request for this, once your PR for Ruby-Ole is merged?
taichi-ishitani commented 5 years ago
  1. Can you please send me a pull request for this, once your PR for Ruby-Ole is merged?

OK. I will send PR when my PR for ruby-ole is merged.

zdavatz commented 5 years ago

Great! Thank you!