Closed taichi-ishitani closed 5 years ago
Aligatoo!
Hi @zdavatz ,
Thank you for merging my PR ! BTW, there're something I have to tell you:
ruby-ole
dependency when my PR (aquasync/ruby-ole#24) is merged and the ruby-ole
gem including my PR is released. In addition you also need to edit .travis.yml and delete USE_LATEST_RUBY_OLE=yes
environment variable.
- Can you please send me a pull request for this, once your PR for Ruby-Ole is merged?
OK. I will send PR when my PR for ruby-ole is merged.
Great! Thank you!
Hi,
I fixed unit test errors caused by frozen string literal. af6206e
To test above changes on CI regression, I also changed files below too:
ruby-ole
gem for frozen string literal support.ruby-ole
gem instead of the original gem.--enable-frozen-string-literal
when ruby version is >= 2.4--enable-frozen-string-literal
option but it seems that standard libraries does not support the feature enough.--enable-frozen-string-literal
option to CI regression.If you don't want to introduce changes of Gemfile, Gemfile.lock and .travis.yml to master repository, please ignore commits 75caf13 and ec10f8b.