Remove invalid worksheet characters

zdavatz / spreadsheet

The Ruby Spreadsheet by ywesee GmbH

http://spreadsheet.ch

GNU General Public License v3.0

1.13k stars 240 forks source link

Closed markedmondson closed 3 years ago

markedmondson commented 3 years ago

Based on http://www.excelcodex.com/2012/06/worksheets-naming-conventions/ (and reported in #70) this removes any invalid worksheet characters (\ , / , * , ? , : , [ , ]) from the name and replaces them with underscores.

zdavatz commented 3 years ago

@markedmondson thank you for the PR. Can please make sure, that all the tests pass? Currently all tests are failing for your PR.

markedmondson commented 3 years ago

@markedmondson thank you for the PR. Can please make sure, that all the tests pass? Currently all tests are failing for your PR.

Yep, looks like it's the same issue across all, I'll take a look.

markedmondson commented 3 years ago

It should be passing now :)