search

zdavatz / spreadsheet

The Ruby Spreadsheet by ywesee GmbH
http://spreadsheet.ch
GNU General Public License v3.0
1.13k stars 240 forks source link

Fix Ruby 3.3.0 warnings #270

Closed mark-young-atg closed 10 months ago

mark-young-atg commented 10 months ago

Running code that uses the spreadsheet gem with Ruby 3.3.0 causes the following warning to be shown

.../gems/spreadsheet-1.3.0/lib/spreadsheet/excel/writer/worksheet.rb:5: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of spreadsheet-1.3.0 to add bigdecimal into its gemspec.

This behaviour is documented with the release of Ruby 3.3.0 https://rubyreferences.github.io/rubychanges/3.3.html#gems-that-are-warned-to-become-bundled-in-the-next-version

zdavatz commented 10 months ago

Thank you for the PR! Can you please make sure, that all the tests pass?

mark-young-atg commented 10 months ago

@zdavatz thank you for your review. Please see my comments on PR#271. My suspicion is that the test failures we are seeing are not related to the changes I've proposed in these two PRs.

zdavatz commented 10 months ago

yes, that is possible, but they still fail, so we need to fix them.