search

zdebruine / RcppML

Rcpp Machine Learning: Fast robust NMF, divisive clustering, and more
GNU General Public License v2.0
89 stars 15 forks source link

Update README.md #32

Closed ttriche closed 2 years ago

ttriche commented 2 years ago

Install RcppSparse before attempting to install RcppML (which will otherwise fail).

It may be preferable to use BiocManager::install() since this will automate installation of any BioC dependencies as well.

zdebruine commented 2 years ago

Thanks, but RcppSparse is no longer required after addressing issue https://github.com/zdebruine/RcppML/issues/31 with 4cdc6a70cbbab3e32ec43da24151c51d0fd0dbff.

There are no BioC dependencies. It would make sense to develop a separate Bioconductor package wrapping SingleCellExperiment and RcppML to integrate with that ecosystem.

ttriche commented 2 years ago

You should remove it from Imports: if so, because otherwise installation fails in the absence of RcppSparse (tested Friday).

Opened #33 to address. From the user perspective, installing the dev version of RcppML depends upon RcppSparse, since installation of the former will fail in the absence of the latter, not due to code dependencies but rather to stated dependencies in DESCRIPTION.

--t

On May 16, 2022, at 8:37 AM, zdebruine @.***> wrote:

 Closed #32.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.