Closed eys123 closed 1 year ago
@eys123 This indeed fixes the numpy version issue! However, it implies that some of the test suite code has broken in a mysterious way, which might imply an issue that isn't currently covered by a test. Let's add a new unittest to the test suite that mimics the code you updated, and make sure we haven't lost any functionality through the latest numpy version.
Patch coverage: 85.71
% and project coverage change: -0.53
:warning:
Comparison is base (
64961f4
) 77.36% compared to head (54d3550
) 76.83%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Merging! We're going to fix the test suite issues in #222
Deprecate lolo; remove unit test for fit_lolo, note deprecation in docstring