zdelrosario / py_grama

Implementation of a grammar of model analysis
https://py-grama.readthedocs.io/en/latest/
MIT License
19 stars 11 forks source link

Deprecate lolo & fix numpy version issue #221

Closed eys123 closed 1 year ago

eys123 commented 1 year ago

Deprecate lolo; remove unit test for fit_lolo, note deprecation in docstring

zdelrosario commented 1 year ago

@eys123 This indeed fixes the numpy version issue! However, it implies that some of the test suite code has broken in a mysterious way, which might imply an issue that isn't currently covered by a test. Let's add a new unittest to the test suite that mimics the code you updated, and make sure we haven't lost any functionality through the latest numpy version.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.53 :warning:

Comparison is base (64961f4) 77.36% compared to head (54d3550) 76.83%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #221 +/- ## ========================================== - Coverage 77.36% 76.83% -0.53% ========================================== Files 87 87 Lines 6737 6740 +3 ========================================== - Hits 5212 5179 -33 - Misses 1525 1561 +36 ``` | [Impacted Files](https://app.codecov.io/gh/zdelrosario/py_grama/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zachary+del+Rosario) | Coverage Δ | | |---|---|---| | [grama/fit/fit\_lolo.py](https://app.codecov.io/gh/zdelrosario/py_grama/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zachary+del+Rosario#diff-Z3JhbWEvZml0L2ZpdF9sb2xvLnB5) | `23.80% <0.00%> (-57.15%)` | :arrow_down: | | [grama/spc.py](https://app.codecov.io/gh/zdelrosario/py_grama/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zachary+del+Rosario#diff-Z3JhbWEvc3BjLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

zdelrosario commented 1 year ago

Merging! We're going to fix the test suite issues in #222