Raise/warn when trying to import hash recursively (or add documentation?)

zdennis / activerecord-import

A library for bulk insertion of data into your database using ActiveRecord.

http://www.continuousthinking.com

MIT License

4.04k stars 618 forks source link

Raise/warn when trying to import hash recursively (or add documentation?) #597

Open dgollahon opened 5 years ago

dgollahon commented 5 years ago

Hi,

I found that recursive import with hashes is not supported (https://github.com/zdennis/activerecord-import/issues/522#issuecomment-397033165) and this is ok, but it took me a little while to realize this after getting a fairly opaque error message. I think it would be an improvement if activerecord-import raised or warned on the combination of recursive: true and an array of hashes or, alternatively, if a warning about this appeared in the hashes section of the readme.

Thanks!

jkowens commented 5 years ago

I think a combination of a warning message and more documentation would be great 👍