search

zdharma-continuum / fast-syntax-highlighting

Feature-rich syntax highlighting for ZSH
BSD 3-Clause "New" or "Revised" License
1.07k stars 76 forks source link

Change zsh standard compatibility #11

Closed grigorii-horos closed 1 year ago

grigorii-horos commented 2 years ago

Function dir should be /functions, see: https://github.com/zdharma-continuum/Zsh-100-Commits-Club/blob/master/Zsh-Plugin-Standard.adoc#funcs-dir

alichtman commented 2 years ago

Ironically, this plug-in and the standard you linked were written by the same person :)

grigorii-horos commented 2 years ago

@alichtman Haha. I know about this, and I have no idea why this was not implemented before.

alichtman commented 2 years ago

Let's also drop all Unicode chars in file names here.

grigorii-horos commented 2 years ago

@vladdoster Done!

pschmitt commented 2 years ago

Renaming all the internal funcs is out of scope for this pr imo.

alichtman commented 2 years ago

While that's true, I'm ok with a "modernize this repo" PR

alichtman commented 2 years ago

On second thought, this PR is now impossible to review efficiently. @pschmitt is right. It should be two PRs. Let's cherrypick 0851e07 to a new PR and I'll approve this one.

FranklinYu commented 2 years ago

If we were to change the function prefix, would we also want to change

https://github.com/zdharma-continuum/Zsh-100-Commits-Club/blob/master/Zsh-Plugin-Standard.adoc#namespacing

as well? Currently it recommends → for hook functions. See also #4.

grigorii-horos commented 2 years ago

Hey @alichtman Done!

Aloxaf commented 2 years ago

I suggest not to remove the unicode prefix.

A unicode prefix is less likely to be a prefix of a normal function/file so that it is less likely to appear in the completion list.

The repo is deleted and I cannot find the old discussion, but the commit which change ascii prefix to unicode preifx is still here: https://github.com/zdharma-continuum/fast-syntax-highlighting/commit/a3242a93399535faccda4896ab5c61a7a6dca1fe

vladdoster commented 2 years ago

On second thought, I just saw @alichtman comment regarding splitting up changes.

@grigorii-horos, Could you please split changes into two PRs to make the changes more atomic?