zdharma-continuum / fast-syntax-highlighting

Feature-rich syntax highlighting for ZSH
BSD 3-Clause "New" or "Revised" License
1.15k stars 75 forks source link

Restore compatibility with Zsh v4.3.11 #7

Closed agkozak closed 2 years ago

agkozak commented 2 years ago

As far as I can tell, the only thing stopping fast-syntax-highlighting from working perfectly as far back as Zsh v4.3.11 is the line

emulate -L zsh -o extendedglob

Zsh < v5.0 does not have an -o option, but you can achieve the same thing with

emulate -L zsh
setopt EXTENDED_GLOB
pschmitt commented 2 years ago

LGTM.

Mind adding a comment in this regard, to explain why don't do this "the right way"? (and link to this issue/PR)

agkozak commented 2 years ago

Done!

pschmitt commented 2 years ago

And merged! Thanks!

agkozak commented 2 years ago

It's a pleasure.