zdharma-continuum / zinit-annex-bin-gem-node

Unmaintained mirror of zinit-zsh/z-a-bin-gem-node
Other
7 stars 9 forks source link

[bug]: Not automatically delete $ZPFX/bin files #13

Closed karbobc closed 7 months ago

karbobc commented 1 year ago

Describe the bug

Not automatically delete $ZPFX/bin files when using zinit delete --all to delete all the installed plugins

Steps to reproduce

  1. install exa plugin
    zinit ice wait lucid id-as nocompile \
    from="gh-r" \
    sbin="bin/exa -> exa" \
    atclone="cp -vf completions/exa.zsh _exa_completion && ln -sfv \$PWD/man/exa.1 $ZINIT[MAN_DIR]/man1" \
    atpull="%atclone" 
    if="(( ! ${+commands[exa]} ))"
    zinit light ogham/exa
  2. delete all the plugins included exa
    zinit delete --all

Expected behavior

bin-gem-node annex: Correctly removed the exa shim from $ZPFX/bin

Screenshots and recordings

No response

Operating System & Version

linux-gnu | | x86_64-pc-linux-gnu | | x86_64 x86_64

Zsh version

zsh 5.8 (x86_64-ubuntu-linux-gnu)

Terminal emulator

xterm-256color

If using WSL on Windows, which version of WSL

No response

Additional context

No response

vladdoster commented 9 months ago

@karbobc,

This has been fixed.

Screenshot 2023-11-30 at 19 03 11
karbobc commented 9 months ago

@vladdoster,

Use zi delete --all --yes instead of zi delete exa --yes.

vladdoster commented 8 months ago

@karbobc,

Fixed in https://github.com/zdharma-continuum/zinit/pull/612

Screenshot 2023-12-24 at 08 47 49
karbobc commented 7 months ago

Thank you for fixing this issue!