zdharma-continuum / zinit-annex-bin-gem-node

Unmaintained mirror of zinit-zsh/z-a-bin-gem-node
Other
7 stars 9 forks source link

maint: Switch from `print -P %F{col-nr}` to `m {col-name}`. #19

Closed psprint closed 1 year ago

psprint commented 1 year ago

The m function is automatically provided for the moment of loading/installing a plugin and it's the same as +zinit-message. With this patch, bgn annex will support theming from https://github.com/zdharma-continuum/zinit/pull/445.

Description

s/print -P --/m …

Motivation and Context

To make messages from bgn annex follow $ZITHEME themes.

Related Issue(s)

https://github.com/zdharma-continuum/zinit/pull/445.

Usage examples

m {pre}bgn-annex:{warn} returned code is {num}1

How Has This Been Tested?

Types of changes

Checklist:

psprint commented 1 year ago

@vladdoster when merge?

psprint commented 1 year ago

The m function is outside the convention because it's for atclone and similar ices - to be as shortest as possible. However here are atclone hooks not ices so I understand that it can be better to use its full name. Should I change it?

vladdoster commented 1 year ago

This breaks the annex.

Screenshot 2023-04-20 at 00 09 42