zdharma-continuum / zinit-annex-bin-gem-node

Unmaintained mirror of zinit-zsh/z-a-bin-gem-node
Other
7 stars 9 forks source link

fix: Fix double shim creating when non-empty sbin'' ice. #22

Closed psprint closed 1 year ago

psprint commented 1 year ago

Currently, e.g. following command:

zi sbin'dstask*->tsk' bpick'dstask-linux-amd*' ghapi from'gh-r' for dstask

Will create two shims, tsk and 'dstask-linux-amd64'.

Description

An unconditional iteration over "" shim with:

for sbin ( $sbins "" )

has been changed to conditional iteration with:

(( !$#sbins )) && sbins+=("")

Motivation and Context

To create shims correctly without extra one.

Related Issue(s)

21

Usage examples

No unscope annex example:

zi sbin'dstask*->tsk' bpick'dstask-linux-amd*' from'gh-r' for naggie/dstask

How Has This Been Tested?

Types of changes

Checklist:

psprint commented 1 year ago

Difference, before:

2022-12-28-113541_1892x631_scrot

After:

2022-12-28-113527_1883x546_scrot

psprint commented 1 year ago

@vladdoster when merged?