[bug]: dl doesn't work - Githubissues

seagle0128 commented 2 years ago

Describe the bug

Recently dl doesn't work in my env. No files are downloaded. My configuration is below.

env:

zsh 5.9 (x86_64-apple-darwin21.3.0)
zinit c3d1bb5

# FZF: fuzzy finder
zinit ice wait lucid as"null" from"gh-r" nocompile src'key-bindings.zsh' sbin \
      dl'https://raw.githubusercontent.com/junegunn/fzf/master/shell/key-bindings.zsh;
         https://raw.githubusercontent.com/junegunn/fzf/master/shell/completion.zsh -> $ZPFX/completions/_fzf_completion;
         https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1
         https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf-tmux.1 -> $ZPFX/share/man/man1/fzf-tmux.1;'
zinit light junegunn/fzf

Steps to reproduce

Enable junegunn/fzf
Run exec zsh

Expected behavior

Download fzf bninary and scripts.

Screenshots and recordings

No response

Operating System & Version

darwin21.3.0 | apple | x86_64 | x86_64 | x86_64 i386

Zsh version

5.9

Terminal emulator

iTerm2

If using WSL on Windows, which version of WSL

No response

Additional context

docwhat commented 2 years ago

I thought I was going mad! Thanks for filing this bug!

vladdoster commented 2 years ago

@docwhat @seagle0128

It seems to work if the src ice is changed to pick (odd, but ¯_(ツ)_/¯)

Can you try the following:

First, remove the current install:

zi delete --yes junegunn/fzf

Next, reinstall:

zi for \
    as"null" \
    dl'https://raw.githubusercontent.com/junegunn/fzf/master/shell/key-bindings.zsh;
       https://raw.githubusercontent.com/junegunn/fzf/master/shell/completion.zsh -> $ZPFX/completions/_fzf_completion;
       https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1
       https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf-tmux.1 -> $ZPFX/share/man/man1/fzf-tmux.1;' \
    from"gh-r" \
    nocompile \
    pick'key-bindings.zsh' \
    sbin \
  @junegunn/fzf

anonymous@saturn ~/.local/share/zinit/plugins/junegunn---fzf master*
ᐳ zi delete  junegunn/fzf --yes
bin-gem-node annex: Correctly removed the fzf shim from $ZPFX/bin

Done (action executed, exit code: 0)

anonymous@saturn ~/.local/share/zinit/plugins/junegunn---fzf
ᐳ zi for \
    as"null" \
    dl'https://raw.githubusercontent.com/junegunn/fzf/master/shell/key-bindings.zsh;
       https://raw.githubusercontent.com/junegunn/fzf/master/shell/completion.zsh -> $ZPFX/completions/_fzf_completion;
       https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1
       https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf-tmux.1 -> $ZPFX/share/man/man1/fzf-tmux.1;' \
    from"gh-r" \
    nocompile \
    pick'key-bindings.zsh' \
    sbin \
  @junegunn/fzf

Downloading junegunn/fzf…
(Requesting `fzf-0.33.0-darwin_amd64.zip'…)
################################################################################################################################################################### 100.0%
ziextract: Unpacking the files from: `fzf-0.33.0-darwin_amd64.zip'…
Archive:  fzf-0.33.0-darwin_amd64.zip
  inflating: fzf
ziextract: Successfully extracted and assigned +x chmod to the file: `fzf'.
patch-dl annex: File key-bindings.zsh downloaded correctly
patch-dl annex: File _fzf_completion downloaded correctly
patch-dl annex: File fzf-tmux.1 downloaded correctly
bin-gem-node annex: Created the fzf shim and set +x on the fzf binary
linkbin annex: sbin ice detected, not doing anything...

anonymous@saturn ~/.local/share/zinit/zinit.git main~1^2
ᐳ zi cd junegunn/fzf
anonymous@saturn ~/.local/share/zinit/plugins/junegunn---fzf master*
ᐳ ls
fzf key-bindings.zsh

seagle0128 commented 2 years ago

@vladdoster Actually the same. pick is unable to fix the issue, and will disable key bindings since there is no src. And I found all info in ._zinit folder is correct. No idea...

❯ zi for \
    as"null" \
    dl'https://raw.githubusercontent.com/junegunn/fzf/master/shell/key-bindings.zsh;
       https://raw.githubusercontent.com/junegunn/fzf/master/shell/completion.zsh -> $ZPFX/completions/_fzf_completion;
       https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1
       https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf-tmux.1 -> $ZPFX/share/man/man1/fzf-tmux.1;' \
    from"gh-r" \
    nocompile \
    pick'key-bindings.zsh' \
    sbin \
  @junegunn/fzf
💡 zini for as"null"  from"gh-r" nocompile pick'key-bindings.zsh' sbin

Downloading junegunn/fzf…
(Requesting `fzf-0.33.0-darwin_amd64.zip'…)
######################################################################### 100.0%
ziextract: Unpacking the files from: `fzf-0.33.0-darwin_amd64.zip'…
Archive:  fzf-0.33.0-darwin_amd64.zip
  inflating: fzf
ziextract: Successfully extracted and assigned +x chmod to the file: `fzf'.
bin-gem-node annex: Created the fzf shim and set +x on the fzf binary

vladdoster commented 2 years ago

@seagle0128 bummer.

However, If you noticed the VCS info in my prompt, I was checked out on older commits. The unfortunate part is i was glad to have it working locally that i forgot to document which specific commits they were for patch-dl && Zinit :^/ .

I'll figure that out again (whatever main~1^2 denotes) and proceed from there. Ideally it'll be a hot-fix, but reverting the changes is reasonable due to time bug has been in.

Regardless, should be fixed one way or the other sometime this weekend.

seagle0128 commented 2 years ago

@vladdoster I didn't notice the commit info 😂 Looking forward to getting the new release. Thanks for your efforts, in advance!

Jackson-soft commented 1 year ago

Is there a follow-up?

vladdoster commented 1 year ago

@Jackson-soft, @seagle0128

Whoops, this fell through the cracks. I am testing the fix now.

vladdoster commented 1 year ago

Following up with @Jackson-soft, @seagle0128, and @jankatins

The problem has been identified and confirmed to be introduced at https://github.com/zdharma-continuum/zinit/pull/227.

I checked out the zdharma-continuum/zinit/pull/227 and it failed, but the parent commit works.

Additionally, I did the inverse (i.e., checkout patch-dl commit before my style changes and used Zinit PR #227 and it failed.

Here is the output:

vladdoster commented 1 year ago

My initial thought is to dynamically set the number of \ (e.g., ternary_expressions_with_substitution or similar).

vladdoster commented 1 year ago

But I can confirm that it works in interactive mode

zsh -i -c "zi for \                                                                                                                                                                          <<<
    as'null' \
    dl'https://raw.githubusercontent.com/junegunn/fzf/master/shell/key-bindings.zsh;
       https://raw.githubusercontent.com/junegunn/fzf/master/shell/completion.zsh -> $ZPFX/completions/_fzf_completion;
       https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1
       https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf-tmux.1 -> $ZPFX/share/man/man1/fzf-tmux.1;' \
    from'gh-r' \
    nocompile \
    pick'key-bindings.zsh' \
    sbin \
  @junegunn/fzf"
[INFO]: minimal zinit configuration

Downloading junegunn/fzf…
(Requesting `fzf-0.34.0-darwin_arm64.zip'…)
############################################################################################################################################################################################ 100.0%
ziextract: Unpacking the files from: `fzf-0.34.0-darwin_arm64.zip'…
Archive:  fzf-0.34.0-darwin_arm64.zip
  inflating: fzf                     
ziextract: Successfully extracted and assigned +x chmod to the file: `fzf'.
patch-dl annex: File key-bindings.zsh downloaded correctly
patch-dl annex: File _fzf_completion downloaded correctly
patch-dl annex: File fzf.1 downloaded correctly
patch-dl annex: File fzf-tmux.1 downloaded correctly
bin-gem-node annex: Created the fzf shim and set +x on the fzf binary

jankatins commented 1 year ago

Easier reproducable example:

λ  zsh -i -c "zi for id-as'dltest' as'null' dl'https://raw.githubusercontent.com/junegunn/fzf/master/shell/key-bindings.zsh' nocompile pick'key-bindings.zsh' @zdharma-continuum/null"

Downloading zdharma-continuum/null… (at label: dltest…)
Cloning into '/home/jan/.local/share/zinit/plugins/dltest'...
⠙ ███████████ OBJ: 100, PACK: 8/8, COMPR: 100%, REC: 100%
[patch-dl annex]: File key-bindings.zsh downloaded correctly

λ  zinit delete dltest -y

Done (action executed, exit code: 0)

λ  zi for id-as'dltest' as'null' dl'https://raw.githubusercontent.com/junegunn/fzf/master/shell/key-bindings.zsh' nocompile pick'key-bindings.zsh' @zdharma-continuum/null

Downloading zdharma-continuum/null… (at label: dltest…)
Cloning into '/home/jan/.local/share/zinit/plugins/dltest'...
⠙ ███████████ OBJ: 100, PACK: 8/8, COMPR: 100%, REC: 100%

I added a print for the array with the annex parts in the end of the plugin.zsh:

echo "---"
print -rC1 -- "$ZINIT_EXTS[@]" |sort | grep 'patch-dl'
echo "---"

✗  zsh -i -c 'echo'
---
11 z-annex-data: zinit-annex-patch-dl hook:!atclone-20 za-patch-dl-handler za-patch-dl-help-null-handler dl\'\'\|patch\'\'
12 z-annex-data: zinit-annex-patch-dl hook:!atpull-20 za-patch-dl-handler za-patch-dl-help-null-handler ''
---

λ  zsh -c 'source .zshrc'
---
11 z-annex-data: zinit-annex-patch-dl hook:!atclone-20 za-patch-dl-handler za-patch-dl-help-null-handler dl\'\'\|patch\'\'
12 z-annex-data: zinit-annex-patch-dl hook:!atpull-20 za-patch-dl-handler za-patch-dl-help-null-handler ''
---

λ  exec zsh
---
11 z-annex-data: zinit-annex-patch-dl hook:\!atclone-20 za-patch-dl-handler za-patch-dl-help-null-handler dl\'\'\|patch\'\'
12 z-annex-data: zinit-annex-patch-dl hook:\!atpull-20 za-patch-dl-handler za-patch-dl-help-null-handler ''
---

(see the escaped and non-escaped exclamation mark after hook:)

For some reason the normal startup is different than both the interactive and non-interactive usage.

jankatins commented 1 year ago

I opened https://github.com/zdharma-continuum/zinit/pull/399 for a possible fix

jankatins commented 1 year ago

@seagle0128 @Jackson-soft Can you comment here or in https://github.com/zdharma-continuum/zinit/pull/399 if the fix works for you?

Jackson-soft commented 1 year ago

@seagle0128 @Jackson-soft Can you comment here or in zdharma-continuum/zinit#399 if the fix works for you?

It doesn't seem to be fixed

seagle0128 commented 1 year ago

@jankatins The patch doesn't work for me, either.

jankatins commented 1 year ago

@seagle0128 @Jackson-soft Can you tell me what zinit config (abbreviated :-)) you have and what should work and what doesn't? E.g. in the above image, it looks a bit like the env var got saved verbatim into the config and is now used as is and therefore cannot be resolved.

Jackson-soft commented 1 year ago

@jankatins

local GH_RAW_URL='https://raw.githubusercontent.com'
zinit ice wait"0b" lucid as"null" from"gh-r" src'key-bindings.zsh' sbin"fzf" \
    dl'${GH_RAW_URL}/junegunn/fzf/master/shell/key-bindings.zsh;
       ${GH_RAW_URL}/junegunn/fzf/master/shell/completion.zsh -> $ZPFX/completions/_fzf_completion;
       ${GH_RAW_URL}/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1'
zinit light junegunn/fzf

seagle0128 commented 1 year ago

My snippet is below. Today I tested again, and the patch seems working for me. I think the failure might be connection issue.

Thank you, @jankatins !

zinit ice wait lucid from"gh-r" nocompile src'key-bindings.zsh' sbin \
      dl'https://raw.githubusercontent.com/junegunn/fzf/master/shell/key-bindings.zsh;
         https://raw.githubusercontent.com/junegunn/fzf/master/shell/completion.zsh -> $ZPFX/completions/_fzf_completion;
         https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1
         https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf-tmux.1 -> $ZPFX/share/man/man1/fzf-tmux.1;'
zinit light junegunn/fzf

Jackson-soft commented 1 year ago

My snippet is below. Today I tested again, and the patch seems working for me. I think the failure might be connection issue.

Thank you, @jankatins !

zinit ice wait lucid from"gh-r" nocompile src'key-bindings.zsh' sbin \
      dl'https://raw.githubusercontent.com/junegunn/fzf/master/shell/key-bindings.zsh;
         https://raw.githubusercontent.com/junegunn/fzf/master/shell/completion.zsh -> $ZPFX/completions/_fzf_completion;
         https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1
         https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf-tmux.1 -> $ZPFX/share/man/man1/fzf-tmux.1;'
zinit light junegunn/fzf

Yes, your configuration is working,but i am not.

jankatins commented 1 year ago

You cannot use environments in single quotes, you need double quotes: e.g. change

    dl'${GH_RAW_URL}/junegunn/fzf/master/shell/key-bindings.zsh;
       ${GH_RAW_URL}/junegunn/fzf/master/shell/completion.zsh -> $ZPFX/completions/_fzf_completion;
       ${GH_RAW_URL}/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1'

to

    dl"${GH_RAW_URL}/junegunn/fzf/master/shell/key-bindings.zsh;
       ${GH_RAW_URL}/junegunn/fzf/master/shell/completion.zsh -> $ZPFX/completions/_fzf_completion;
       ${GH_RAW_URL}/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1"

And it should work

Jackson-soft commented 1 year ago

You cannot use environments in single quotes, you need double quotes: e.g. change

    dl'${GH_RAW_URL}/junegunn/fzf/master/shell/key-bindings.zsh;
       ${GH_RAW_URL}/junegunn/fzf/master/shell/completion.zsh -> $ZPFX/completions/_fzf_completion;
       ${GH_RAW_URL}/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1'

to

    dl"${GH_RAW_URL}/junegunn/fzf/master/shell/key-bindings.zsh;
       ${GH_RAW_URL}/junegunn/fzf/master/shell/completion.zsh -> $ZPFX/completions/_fzf_completion;
       ${GH_RAW_URL}/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1"

And it should work

yes, you are right

seagle0128 commented 1 year ago

Any update, @jankatins ?

jankatins commented 1 year ago

From my point, I'm waiting for a review by a zinit maintainer, eg. @vladdoster

vladdoster commented 1 year ago

I can confirm the bug is fixed.

Jackson-soft commented 1 year ago

This problem reappeared.

vladdoster commented 1 year ago

This problem reappeared.

@Jackson-soft Do you mind opening a new issue with details?

vladdoster commented 1 year ago

ᐳ zi delete junegunn/fzf -y
No such (plugin or snippet): junegunn/fzf.

~/.local/share/zinit/zinit.git main*
ᐳ zinit ice wait lucid from"gh-r" nocompile src'key-bindings.zsh' sbin \
      dl"https://raw.githubusercontent.com/junegunn/fzf/master/shell/key-bindings.zsh;
         https://raw.githubusercontent.com/junegunn/fzf/master/shell/completion.zsh -> $ZPFX/completions/_fzf_completion;
         https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1
         https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf-tmux.1 -> $ZPFX/share/man/man1/fzf-tmux.1;"
zinit light junegunn/fzf

Downloading junegunn/fzf…
(Requesting `fzf-0.35.0-darwin_amd64.zip'…)
###################################################################################################################################################################################################################################################### 100,0%
[ziextract] Unpacking the files from: `fzf-0.35.0-darwin_amd64.zip'…
Archive:  fzf-0.35.0-darwin_amd64.zip
  inflating: fzf                     
[ziextract] Successfully extracted and assigned +x chmod to the file: fzf.
[patch-dl annex]: File key-bindings.zsh downloaded correctly
[patch-dl annex]: File _fzf_completion downloaded correctly
[patch-dl annex]: File fzf-tmux.1 downloaded correctly
bin-gem-node annex: Created the fzf shim and set +x on the fzf binary
[linkbin annex] sbin ice detected, not doing anything...
~/.local/share/zinit/zinit.git main*
ᐳ git log --summary -1
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
commit a27d7e0b572384e961fe3fc7c3eb740b54a8c6f9 (HEAD -> main, tag: v3.8.0, origin/main, origin/HEAD)
Author: Vladislav Doster <mvdoster@gmail.com>
Date:   Mon Nov 7 02:41:04 2022 +0000

    release: v3.7.0 → v3.8.0

    # [3.8.0](https://github.com/zdharma-continuum/zinit/compare/v3.7.0...v3.8.0) (2022-11-07)

    ### Bug Fixes

    * account for systems where musl is present ([#269](https://github.com/zdharma-continuum/zinit/issues/269)) ([8620574](https://github.com/zdharma-continuum/zinit/commit/8620574a5533695525260fd88df8d249c701217f))
    * alist repository for gh-r test ([#305](https://github.com/zdharma-continuum/zinit/issues/305)) ([fb3c082](https://github.com/zdharma-continuum/zinit/commit/fb3c082551ee9f48676c3183d5a4e9e842d3d874))
    * allow zinit to be run from non-interactive scripts ([#227](https://github.com/zdharma-continuum/zinit/issues/227)) ([c3d1bb5](https://github.com/zdharma-continuum/zinit/commit/c3d1bb586c77a98566c552358fd9aee084e30da8)), closes [#199](https://github.com/zdharma-continuum/zinit/issues/199)
    * broken yaml syntax in issue template ([#355](https://github.com/zdharma-continuum/zinit/issues/355)) ([f729e06](https://github.com/zdharma-continuum/zinit/commit/f729e065db88a5cd0daa8a6f2bd2f8ee0439545a))
    * calico gh-r zunit test ([#356](https://github.com/zdharma-continuum/zinit/issues/356)) ([56fb9e0](https://github.com/zdharma-continuum/zinit/commit/56fb9e0b1df21de809a2efc935882b49e9161618))
    * change ctags symbols browser key  binding from `ctrl-k` to `alt-Q` ([#387](https://github.com/zdharma-continuum/zinit/issues/387)) ([7f6dc7d](https://github.com/zdharma-continuum/zinit/commit/7f6dc7da6c824b30c0e8e30ae0ecbda5be118e68)), closes [#386](https://github.com/zdharma-continuum/zinit/issues/386)
    * Do not try to escape exclamation marks ([#399](https://github.com/zdharma-continuum/zinit/issues/399)) ([0e55b2e](https://github.com/zdharma-continuum/zinit/commit/0e55b2ea673915c462af752ee7d46fff55e6f436))
    * docs workflow should fail if out-of-date ([#278](https://github.com/zdharma-continuum/zinit/issues/278)) ([07cde66](https://github.com/zdharma-continuum/zinit/commit/07cde660081c91382ce73b60485839710154c7c6))
    * Don't error if $OPTS is not yet defined in .zinit-compinit call ([44765e0](https://github.com/zdharma-continuum/zinit/commit/44765e0bcb8d3f1ee3eb55286e33ad17b8c72a5e))
    * filter by runtime detected CPU before compiled CPU ([#304](https://github.com/zdharma-continuum/zinit/issues/304)) ([a4dc13f](https://github.com/zdharma-continuum/zinit/commit/a4dc13f66a65c4fa52953104c13e44a7d7c0a945)), closes [#287](https://github.com/zdharma-continuum/zinit/issues/287)
    * gh-r & plugin zunit tests ([dd12fce](https://github.com/zdharma-continuum/zinit/commit/dd12fce3f49db284de7cf18a03ef891cc46bc7cc))
    * gh-r filters i686 (32 bit) for x86_64 ([#226](https://github.com/zdharma-continuum/zinit/issues/226)) ([57f0d82](https://github.com/zdharma-continuum/zinit/commit/57f0d82118ed626f04d4b9b8b26de48c9d7e0956)), closes [#225](https://github.com/zdharma-continuum/zinit/issues/225)
    * gh-r logic ignores [36]86 assets ([#235](https://github.com/zdharma-continuum/zinit/issues/235)) ([d60638f](https://github.com/zdharma-continuum/zinit/commit/d60638f2217875056a061b3411c4bcc678dce5f6)), closes [#225](https://github.com/zdharma-continuum/zinit/issues/225) [#246](https://github.com/zdharma-continuum/zinit/issues/246) [#247](https://github.com/zdharma-continuum/zinit/issues/247)
    * gh-r removes linux32 assets on 64 bit OS ([1864c0b](https://github.com/zdharma-continuum/zinit/commit/1864c0be09faa0e4d9a7c549cafed7d296d7517e))
    * gh-r retrieves release data GH REST API  ([#373](https://github.com/zdharma-continuum/zinit/issues/373)) ([4a2a120](https://github.com/zdharma-continuum/zinit/commit/4a2a120b341793b1abaef5f12fbb4808277d8570)), closes [#374](https://github.com/zdharma-continuum/zinit/issues/374)
    * modify regex in gh-r for assets to not consider for selection ([#244](https://github.com/zdharma-continuum/zinit/issues/244)) ([6ef8439](https://github.com/zdharma-continuum/zinit/commit/6ef84398b2c92073d88f440dfbfd554cb8e75343))
    * more cleaning up urls ([672ae51](https://github.com/zdharma-continuum/zinit/commit/672ae514142b433708ea10486556fe3f0ba54e3e)), closes [#47](https://github.com/zdharma-continuum/zinit/issues/47)
    * names of ctag Make target deps ([#407](https://github.com/zdharma-continuum/zinit/issues/407)) ([9987d5c](https://github.com/zdharma-continuum/zinit/commit/9987d5c781d4a95698ed649dc59b11c34006b1c1))
    * package are broken again ([24f10f6](https://github.com/zdharma-continuum/zinit/commit/24f10f6367cbab6039bd0c1ca07dd9449bbc3557))
    * permissions for PR labeler GH action workflow ([#236](https://github.com/zdharma-continuum/zinit/issues/236)) ([8a0d567](https://github.com/zdharma-continuum/zinit/commit/8a0d5678d1ee0eeed91d2c3a094578a2cd39ba04))
    * read without -r is generally bad. ([00c70a4](https://github.com/zdharma-continuum/zinit/commit/00c70a434d50a1591bcdc73185150b2fdce96c77))
    * remove curl option "--tcp-fastopen" which is not always available ([#299](https://github.com/zdharma-continuum/zinit/issues/299)) ([308c9d4](https://github.com/zdharma-continuum/zinit/commit/308c9d4cd82f3e41d2ae21ff31fba0dc4a7c6cb5))
    * remove macOS 10.5 & 11 from test matrix ([c613193](https://github.com/zdharma-continuum/zinit/commit/c61319378df5b0deae68fc467b9a2449fcf67336))
    * remove use less line ([4f87076](https://github.com/zdharma-continuum/zinit/commit/4f870766011d36c871d8afd07afe56733c8de76d))
    * rename `docs` to `doc` to match doc dir ([#212](https://github.com/zdharma-continuum/zinit/issues/212)) ([3a7dc95](https://github.com/zdharma-continuum/zinit/commit/3a7dc95f02340fb56693ca0f304e31be8c8a9652))
    * rm linux32 assets in aarch64/arm64 gh-r regex ([#414](https://github.com/zdharma-continuum/zinit/issues/414)) ([529aa20](https://github.com/zdharma-continuum/zinit/commit/529aa20f42a249f609b9e8248d6fd00d609a35ce))
    * syntax error when checking for `realpath` command  ([#259](https://github.com/zdharma-continuum/zinit/issues/259)) ([05559eb](https://github.com/zdharma-continuum/zinit/commit/05559ebdbcda77622daaf3935d20fdf9b9c09c6c)), closes [#257](https://github.com/zdharma-continuum/zinit/issues/257)
    * trigger for PR labeler GH action workflow ([#237](https://github.com/zdharma-continuum/zinit/issues/237)) ([49af866](https://github.com/zdharma-continuum/zinit/commit/49af86688bc8c5882744a679f9c0094e2f4c7fa6))
    * typo & triggers in documentation workflow ([#308](https://github.com/zdharma-continuum/zinit/issues/308)) ([161d7c1](https://github.com/zdharma-continuum/zinit/commit/161d7c1ee1fc2bbb43442cd90b48e502bf62603f))
    * unmatched "(" in windows gh-r patterns ([#280](https://github.com/zdharma-continuum/zinit/issues/280)) ([1f4ba5a](https://github.com/zdharma-continuum/zinit/commit/1f4ba5ae0ccf928d1914dc3a11d00393e0fd94a8))
    * update `zdharma` to `zdharma-continuum` ([66b1700](https://github.com/zdharma-continuum/zinit/commit/66b17007523321f9afee91dbe75b487de5db4fec))
    * update docs for new jq-check ([6207427](https://github.com/zdharma-continuum/zinit/commit/62074272563f88a32a701f56f914297930a9da19))
    * use [*] inside arbitrary strings. ([73a8c92](https://github.com/zdharma-continuum/zinit/commit/73a8c92d43f57bca514e44b9fed14e941168c61f))
    * workflow pkg mgmt due to base OS changes ([195f72d](https://github.com/zdharma-continuum/zinit/commit/195f72d54b80051fc71d1f73909f5dabe6745649))
    * ziextract execs discovery regex ([#410](https://github.com/zdharma-continuum/zinit/issues/410)) ([105b38a](https://github.com/zdharma-continuum/zinit/commit/105b38a195e2a67eaba9d7a69bcef7738c57d12d))
    * zunit install in GH workflow ([#412](https://github.com/zdharma-continuum/zinit/issues/412)) ([f4787dc](https://github.com/zdharma-continuum/zinit/commit/f4787dcac803ed9055c4032c516dba66737beebf))

    ### Features

    * ability to set program for `zinit ls` to use ([#221](https://github.com/zdharma-continuum/zinit/issues/221)) ([bad7af3](https://github.com/zdharma-continuum/zinit/commit/bad7af3ae2d8aab18feb11a0251987fe3c08c31b)), closes [#170](https://github.com/zdharma-continuum/zinit/issues/170)
    * add `-a` (actual time) to `zinit times` cmd ([#223](https://github.com/zdharma-continuum/zinit/issues/223)) ([450d3c1](https://github.com/zdharma-continuum/zinit/commit/450d3c10a8f6728ee8c76bfb99f777658b8d3f35))
    * add `krew` and `prebuilt-ripgrep` gh-r zunit tests ([#267](https://github.com/zdharma-continuum/zinit/issues/267)) ([f25b4ae](https://github.com/zdharma-continuum/zinit/commit/f25b4ae2b9951bf0d1306a17ef512a1868211b78))
    * add compile vim from source zunit test ([#232](https://github.com/zdharma-continuum/zinit/issues/232)) ([126528c](https://github.com/zdharma-continuum/zinit/commit/126528ccd50e98c0e71f06971ae16aceb571fb97))
    * add configure"" ice ([#334](https://github.com/zdharma-continuum/zinit/issues/334)) ([40a46c6](https://github.com/zdharma-continuum/zinit/commit/40a46c6d2250af7e01d91b2f8ec3e01cf392c3d1))
    * add GH action to remove old workflow logs ([#248](https://github.com/zdharma-continuum/zinit/issues/248)) ([6647bdc](https://github.com/zdharma-continuum/zinit/commit/6647bdc31c5b82378195ce71055099a7b36734a1))
    * add PR labeler to show what parts of Zinit are changed ([#211](https://github.com/zdharma-continuum/zinit/issues/211)) ([42e83d7](https://github.com/zdharma-continuum/zinit/commit/42e83d7f99254c16e408f52848b914f7aa264372))
    * add releases via semantic-release ([73542b4](https://github.com/zdharma-continuum/zinit/commit/73542b490981e43adca4a09b64c327fe811d01e1))
    * add releases via semantic-release ([#415](https://github.com/zdharma-continuum/zinit/issues/415)) ([cfa2f0e](https://github.com/zdharma-continuum/zinit/commit/cfa2f0ebcd674706d5cb91533cf362f6f4ddd7ee))
    * expand linted file types to markdown and shell ([96fe03f](https://github.com/zdharma-continuum/zinit/commit/96fe03f85baf8eae33270a09a5ca82f108f6cc25))
    * **git-process-output:** simplify progress-bar ([#204](https://github.com/zdharma-continuum/zinit/issues/204)) ([c888917](https://github.com/zdharma-continuum/zinit/commit/c888917edbafa3772870ad1f320da7a5f169cc6f))
    * update output messaging to be more informative ([047320a](https://github.com/zdharma-continuum/zinit/commit/047320a9234be4de8299ff4796e28e2363e77984))

Jackson-soft commented 1 year ago

My mistake @vladdoster

I'll try again, it's ok

vladdoster commented 1 year ago

@Jackson-soft no worries, hopefully it works this time. Keep me posted!

vladdoster commented 1 year ago

I came up with a condensed (it can be condensed more) version of the fzf recipe.

zi for \
    dl="$(print -c https://raw.githubusercontent.com/junegunn/fzf/master/{shell/{'key-bindings.zsh;','completion.zsh -> _fzf;'},man/{'man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1;','man1/fzf-tmux.1 -> $ZPFX/share/man/man1/fzf-tmux.1;'}})" \
    from'gh-r' \
    nocompile \
    as'completion' \
    sbin \
    wait \
    src'key-bindings.zsh' \
  @junegunn/fzf

Jackson-soft commented 1 year ago

I found that when running zinit update,dl doesn't work,Do you have the same situation here? @vladdoster

vladdoster commented 1 year ago

I found that when running zinit update,dl doesn't work,Do you have the same situation here? @vladdoster

@Jackson-soft, could you share a code snippet?

Jackson-soft commented 1 year ago

zinit ice wait"0b" lucid as"null" from"gh-r" src"key-bindings.zsh" sbin"fzf" \
    dl="$(print -c https://raw.githubusercontent.com/junegunn/fzf/master/{shell/{'key-bindings.zsh;','completion.zsh -> _fzf;'},'man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1;'})" 
zinit light junegunn/fzf

vladdoster commented 1 year ago

I see fzf had a release three days ago. So if I'm following correctly, the files in the dl'' ice did not get updated?

Jackson-soft commented 1 year ago

yes, the files in the dl'' ice did not get update,Only the binaries were updated.previously re-downloaded the files in the dl'' ice.

ngocphamm commented 1 year ago

I just got this exact issue with @Jackson-soft. Wanted to update fzf for a release a few days back or so.

~ »  zinit update junegunn/fzf
Alias tip: zini update junegunn/fzf
(Requesting `fzf-0.36.0-darwin_amd64.zip', version 0.36.0... Current version: 0.35.1.)
######################################################################################################################################################################################################################## 100.0%
[ziextract] Unpacking the files from: `fzf-0.36.0-darwin_amd64.zip'...
Archive:  fzf-0.36.0-darwin_amd64.zip
  inflating: fzf
[ziextract] Successfully extracted and assigned +x chmod to the file: fzf.

[linkbin annex] Re-created the fzf soft link and set +x on the fzf binary

It then breaks my shell because there's no files to source anymore

lbin"!fzf*" \
    dl'https://raw.githubusercontent.com/junegunn/fzf/master/bin/fzf-tmux;
       https://raw.githubusercontent.com/junegunn/fzf/master/shell/completion.zsh;
       https://raw.githubusercontent.com/junegunn/fzf/master/shell/key-bindings.zsh;
       https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf-tmux.1;
       https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf.1' \
    multisrc"{key-bindings,completion}.zsh" \
    junegunn/fzf \

.zinit-load-plugin:source:112: no such file or directory: /Users/ngoc/.local/share/zinit/plugins/junegunn---fzf/key-bindings.zsh
.zinit-load-plugin:source:112: no such file or directory: /Users/ngoc/.local/share/zinit/plugins/junegunn---fzf/completion.zsh

Jackson-soft commented 1 year ago

yes, the files in the dl'' ice did not get update,Only the binaries were updated.previously re-downloaded the files in the dl'' ice.

@vladdoster Can you take a look at this question?

jankatins commented 1 year ago

Also reported this at the zinit repo: https://github.com/zdharma-continuum/zinit/issues/467

Jackson-soft commented 1 year ago

Also reported this at the zinit repo: zdharma-continuum/zinit#467

fine.

jankatins commented 1 year ago

If I change my zinit call to include a atpull"%atclone" (despite no atclone ice!), an update does the right thing:

λ zinit light-mode depth"1" for \
  @zdharma-continuum/zinit-annex-binary-symlink \
  @zdharma-continuum/zinit-annex-bin-gem-node \
  @zdharma-continuum/zinit-annex-default-ice \
  @zdharma-continuum/zinit-annex-patch-dl \
  @zdharma-continuum/zinit-annex-readurl

λ zinit default-ice --quiet as'null' from"gh-r" lbin'!' lucid nocompile completions

λ zinit lbin'!' atpull"%atclone" completions \
    dl'https://raw.githubusercontent.com/junegunn/fzf/master/bin/fzf-tmux;
       https://raw.githubusercontent.com/junegunn/fzf/master/shell/completion.zsh -> _fzf_completion;
       https://raw.githubusercontent.com/junegunn/fzf/master/shell/key-bindings.zsh;
       https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf-tmux.1 -> $ZPFX/man/man1/fzf-tmux.1;
       https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/man/man1/fzf.1' \
    src"key-bindings.zsh" \
    for @junegunn/fzf

λ  rm ~/.local/share/zinit/plugins/junegunn---fzf/._zinit/is_release

λ  zinit update junegunn/fzf
(Requesting `fzf-0.38.0-darwin_amd64.zip', version 0.38.0…)
########################################################################################################################################################################### 100.0%
[ziextract] Unpacking the files from: `fzf-0.38.0-darwin_amd64.zip'…
Archive:  fzf-0.38.0-darwin_amd64.zip
  inflating: fzf
[ziextract] Successfully extracted and assigned +x chmod to the file: fzf.
Installed 0 completions. They are stored in the $INSTALLED_COMPS array.
Skipped installing 1 completions. They are stored in the $SKIPPED_COMPS array.

[patch-dl annex] fzf-tmux downloaded successfully
[patch-dl annex] _fzf_completion downloaded successfully
[patch-dl annex] key-bindings.zsh downloaded successfully
[patch-dl annex] fzf-tmux.1 downloaded successfully
[patch-dl annex] fzf.1 downloaded successfully
[linkbin annex] Re-created the fzf soft link and set +x on the fzf binary

I've no more ideas what's going on here, https://github.com/zdharma-continuum/zinit/issues/467 has some more debugging but I'm in a dead end and call it quits for now.

jankatins commented 1 year ago

Changing the registering to actually run post pull works for me and is in this PR: https://github.com/zdharma-continuum/zinit-annex-patch-dl/pull/11

zdharma-continuum / zinit-annex-patch-dl

[bug]: dl doesn't work #6

Describe the bug

Steps to reproduce

Expected behavior

Screenshots and recordings

Operating System & Version

Zsh version

Terminal emulator

If using WSL on Windows, which version of WSL

Additional context