search

zdharma-continuum / zinit-module

zsh module for automatically compiling sourced files
Other
20 stars 6 forks source link

Failed to load with zsh 5.8.1 #4

Open mowgli opened 2 years ago

mowgli commented 2 years ago

After update to zsh 5.8.1, I get the following error:

/home/klaus/.zsh/zshrc/10_zshplugin:26: failed to load module `zdharma_continuum/zinit': /home/klaus/.zinit/module/Src/zdharma_continuum/zinit.so: undefined symbol: bshin
Aloxaf commented 2 years ago

A simple fix is available here: https://github.com/Aloxaf/zinit-module/commit/ee6b59e61e781a784be5a3413ec0f2e673dd918c, but I am not sure how to make a full PR because it will introduce breaking changes.

Aloxaf commented 2 years ago

I have the following ideas:

  1. Create a patch and apply it when zsh version is-at-least 5.8.1. See https://github.com/Aloxaf/zinit-module/commit/f7c4c272cfa777b1ca83d4c6dfb6484a05dea1b2, this is a very simple solution.
  2. Create different branch for each zsh version which has breaking changes. In this case, we can also update the whole code base to 5.8.1 so that we can have the best compatibility.
3v1n0 commented 2 years ago

Should probably also use a versioned name at this point, so that can be easy to share the home when it's used by different zsh versions (for example you use your home folder / dotfiles in multiple distros)

mindbound commented 2 years ago

After applying @Aloxaf's patch, I'm getting the following error on load:

(eval):ZinitModule_:1: can't write zwc file: /proc/self/fd/14.zwc

Using zsh 5.8.1 on Arch Linux. Please advise.

mojolo commented 2 years ago

How would one apply this patch?

It seems that the Aloxaf fixed branches (fix_zsh_5.8.1 AND zsh_5.8.1_patch) are a commit behind the main zdharma-continuum/zinit-module. Specifically, the Aloxaf mod-install.sh refers to zdharma-continuum/zinit module but needs to be updated to zdharma-continuum/zinit-module.

jimeh commented 7 months ago

Any progress with this? I'm having the same error on Fedora 39 with ZSH 5.9.