search

zdharma-continuum / zinit

đŸŒ» Flexible and fast ZSH plugin manager
MIT License
2.95k stars 126 forks source link

Fix #395 #397

Closed Freed-Wu closed 1 year ago

Freed-Wu commented 1 year ago

Description

Create ._zinit/.gitignore which content is '*' for every plugin.

Motivation and Context

zinit create ._zinit to store some metadata. However, this metadata should not be added to git.

Related Issue(s)

Fix #395.

I am not sure if https://github.com/zdharma-continuum/zinit/blob/main/share/template-plugin/zsh.gitignore#L12 should be removed. Maybe we should support old zinit? And I think this file should be pushed to https://github.com/github/gitignore/ to let more zsh plugin developers use.

How Has This Been Tested?

I have tested it can work for me.

Types of changes

Checklist:

vladdoster commented 1 year ago

I understand the reason, but I can't think of a situation where ._zinit would be added to git?

Freed-Wu commented 1 year ago

a situation where ._zinit would be added to git

Exist, such as user use ~/.local/share/zinit/plugins/XXX to develop their own plugin and use git to VCS.

vladdoster commented 1 year ago

Can you rebase your branch onto main so the checks will pass?

Freed-Wu commented 1 year ago

OK.

Freed-Wu commented 1 year ago

Seems that some test failed.

Freed-Wu commented 1 year ago

What happened? @vladdoster 

 Downloading alist-org/alist…

gh-r: failed to find the correct GitHub release asset to download.
Freed-Wu commented 1 year ago

What happened? @vladdoster

 Downloading alist-org/alist…

gh-r: failed to find the correct GitHub release asset to download.

Is it due to network problem? Can anyone rerun the test to take a look?

Freed-Wu commented 1 year ago

@vladdoster @pschmitt

pschmitt commented 1 year ago

@vladdoster @pschmitt

Don't. Fix the ci instead.

vladdoster commented 1 year ago

@Freed-Wu,

Your branch is out of date. Rebase your branch using the zdharma-continuum main branch.

vladdoster commented 1 year ago

@Freed-Wu,

I went ahead and rebased your branch.

vladdoster commented 1 year ago

@Freed-Wu,

Don't worry about the numerous commits. I'll merge this once unit tests pass and will regenerate the docs in a separate PR.

Thanks again for your PR :^)

Freed-Wu commented 1 year ago

All checks have passed.