psprint commented 1 year ago

Description

Some distributions don't provide zinit.1 man page, so first check if it's available.

Motivation and Context

To fix #418.

Related Issue(s)

418

Usage examples

How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

alichtman commented 1 year ago

~~Seems like a reasonable fix?~~

Edit: I read the linked issue and the patch again and I'm not sure that this fixes the actual issue. I'd like to understand exactly why this is happening before merging a fix.

That manpage has been in doc/zinit.1 for a while. And the archive I downloaded from https://github.com/zdharma-continuum/zinit/archive/refs/tags/v3.8.0.tar.gz has doc/zinit.1.

Wasn't right to merge this.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.9.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

zdharma-continuum / zinit

Copy doc/zinit.1 only if it exists. Fixes #418. #419