Fix highlighting for mcedit.

[psprint]

mcedit doesn't recognize " embedded in a substitution, breaking highlighting.

So remove it as it's not needed.

Description

The " in ${…} isn't needed and it breaks syntax highlighting in mcedit.

Motivation and Context

Related Issue(s)

Usage examples

How Has This Been Tested?

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have added tests to cover my changes.
• [x] All new and existing tests passed.

[vladdoster]

@psprint, can you provide a screenshot of the behavior this fixes?

[vladdoster]

Also, the title of this PR is a bit misleading, IMO. You're removing quoting from a substitution. The actual change seems good, but could you show where this issue happens in mcedit?

Also, I just realized there is a bug in this code if the comment is correct.

[psprint]

@vladdoster, I've updated the commit message. Effects are:

• before

• after

[alichtman]

This sounds like an mcedit bug, and not a zinit bug.

mcedit doesn't recognize " embedded in a substitution, breaking highlighting.

I'm not inclined to change zinit to work around an mcedit highlighting bug.

[psprint]

Ok, I agree.