search

zdharma-continuum / zinit

🌻 Flexible and fast ZSH plugin manager
MIT License
2.95k stars 126 forks source link

[bug]: PR #409 breaks plugins #427

Closed vladdoster closed 1 year ago

vladdoster commented 1 year ago

What happened?

Plugin functionality breaks

Steps to reproduce

N/A

Relevant output

No response

Screenshots and recordings

No response

Operating System & Version

OS: darwin22.1.0 | Vendor: apple | Machine: arm | CPU: arm64 | Processor: arm | Hardware: arm64

Zsh version

zsh 5.9 (arm-apple-darwin22.1.0)

Terminal emulator

xterm-kitty

If using WSL on Windows, which version of WSL

No response

Additional context

No response

Code of Conduct

vladdoster commented 1 year ago

@psprint

imhansai commented 1 year ago

Yes, please check. The temporary solution is to execute git reset --hard 1e5c0e9389680b94c0505e06f45f72331d61f041

vladdoster commented 1 year ago

@imhansai, the following is a better solution git reset --hard HEAD^.

vladdoster commented 1 year ago

After a bit more investigation, it breaks the wait ice.

imhansai commented 1 year ago

@imhansai, the following is a better solution git reset --hard HEAD^.

Yeah，return to the previous commit :)

psprint commented 1 year ago

I've updated #409, it should work now.

On Sun, 20 Nov 2022 at 09:06, 从现在开始 @.***> wrote:

@imhansai https://github.com/imhansai, the following is a better solution git reset --hard HEAD^.

Yeah，return to the previous commit :)

— Reply to this email directly, view it on GitHub https://github.com/zdharma-continuum/zinit/issues/427#issuecomment-1321075509, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOE4CHPRPZMKO4SPDLZW53WJHSYHANCNFSM6AAAAAASFWQ2EY . You are receiving this because you were mentioned.Message ID: @.***>

-- Best regards, Sebastian Gniazdowski

vladdoster commented 1 year ago

@psprint You need to open a new PR.

vladdoster commented 1 year ago

@imhansai reverted commit 4938e84 for the time being

jankatins commented 1 year ago

And again broken with the merge of https://github.com/zdharma-continuum/zinit/pull/429

jankatins commented 1 year ago

I experimented a bit:

With the broken commit:

zsh -x -l 2>&1 | grep "zsh.1: @zinit-scheduler"

~/.local/share/zinit/zinit.git on  jan-add-completions-ice (23a21d3e) [⇡]
[00:23:27] λ  0 // zsh.1: @zinit-scheduler following
0 // zsh.1: @zinit-scheduler following following
0 // zsh.1: @zinit-scheduler following following
0 // zsh.1: @zinit-scheduler following following
0 // zsh.1: @zinit-scheduler following following

(in the middle, my prompt is shown and then the scheduler lines appear until I press ^C^D)

Without the broken commit, the above doesn't show anything apart from the prompt.

Maybe that's an idea how to write a test for the scheduler?

vladdoster commented 1 year ago

@jankatins Reverted in #432.

vladdoster commented 1 year ago

Closing due to lack of activity.