zdharma-continuum / zinit

🌻 Flexible and fast ZSH plugin manager

MIT License

2.89k stars 124 forks source link

perf: Make scheduler be called in 10 seconds interval if no tasks #429

Closed psprint closed 1 year ago

psprint commented 1 year ago

Description

Fixed #409

Motivation and Context

Related Issue(s)

409

Usage examples

How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

vladdoster commented 1 year ago

Please rebase your branch.

psprint commented 1 year ago

I've rebased the branch.

jankatins commented 1 year ago

After having this commit in the zinit repo, I've no plugins loaded anymore. It seems to be, this again broke the wait ice, removing all wait ices let the plugins get loaded again.

Also verified by reverting this commit on top of #417 (which I run locally) and starting with wait ices

vladdoster commented 1 year ago

@psprint There needs to be a zunit test for this change so we avoid reverting it again.

mustaqimM commented 1 year ago

This doesn't seem to lower the CPU usage:

vladdoster commented 1 year ago

This doesn't seem to lower the CPU usage:

@mustaqimM The commit was reverted.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.9.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: