Testing wait ice and plugin effects unloading

psprint commented 1 year ago

Description

I've read about the need on testing wait ice. The following could work, but it doesn't. I'm commiting it so that some other eyes might come up with a solution.

Motivation and Context

Related Issue(s)

Usage examples

How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

psprint commented 1 year ago

@vladdoster @pschmitt: The test works correctly now because:

eval is used to run the test command instead of run,
@zinit-scheduler burst is used to flush all wait plugins.

psprint commented 1 year ago

@vladdoster @pschmitt @jankatins I've checked that the added test correctly detects bug breaking of the wait'' ice from #429 and fixes #409.

psprint commented 1 year ago

@vladdoster @pschmitt @jankatins

Added plugin unloading tests (they are based on load''/unload'' ices, so they are tested too).

psprint commented 1 year ago

@vladdoster @pschmitt @alichtman: ping?

zdharma-continuum / zinit