zdharma-continuum / zinit

🌻 Flexible and fast ZSH plugin manager

MIT License

2.89k stars 124 forks source link

feat: new ice build'' #458

Closed psprint closed 1 year ago

psprint commented 1 year ago

Description

A new shorthand for null/as'null', configure'' and make'' ices.

Motivation and Context

Providing over and over again as'null' configure make'install' seems boring, so a new ice build'' has been introduced, that enables the three ices.

Related Issue(s)

345 #334 #351

Usage examples

zi id-as from"gitlab.matrix.org" build for matrix-org/olm

instead of:

zi id-as as"null" from"gitlab.matrix.org" configure make'install' \
        for matrix-org/olm

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

psprint commented 1 year ago

I've also added null'' ice to be automatically triggered from build''. There is also nonull ice to block this.

psprint commented 1 year ago

@vladdoster: Why this PR isn't merged yet? It adds a pull-in of three ices via a single ice build''. Thus, it's an isolated, safe feature, basically 2 lines of code.

vladdoster commented 1 year ago

Can you update the README.md?

psprint commented 1 year ago

Can you update the README.md?

@vladdoster: I've added description of build'' ice. I've also added a param'' ice alias env'', which allows to create a local -x … params. Didn't document it because the PR with param'' documentation isn't merged… #402

vladdoster commented 1 year ago

@psprint,

If I understand, this would basically force users to either use of lbin, sbin, and bin-gem-node with configure and make ices OR the build ice , right?

Using your example,

zi id-as from"gitlab.matrix.org" build for matrix-org/olm

How do I pass different targets to make?

Say I want foo and bar targets, would it be:

zi id-as from"gitlab.matrix.org" build make'foo bar' for matrix-org/olm

zi id-as from"gitlab.matrix.org" build'foo bar' for matrix-org/olm

or is build just to abstract only the following condition:

configure make'install' as'null'

How do I pass flags to configure?

psprint commented 1 year ago

No, everything works correctly , it's only a pull-in ice that pulls two other ices.

sob., 29 kwi 2023, 05:06 użytkownik vladislav doster < @.***> napisał:

@psprint https://github.com/psprint,

If I understand, this would not allow use of lbin, sbin, and bin-gem-node, right?

— Reply to this email directly, view it on GitHub https://github.com/zdharma-continuum/zinit/pull/458#issuecomment-1528565295, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOE4CFVVHTFZLKHSQSKE53XDSAVDANCNFSM6AAAAAATZBSZEI . You are receiving this because you were mentioned.Message ID: @.***>

psprint commented 1 year ago

@vladdoster: I've added the test for build ice.