zdharma-continuum / zinit

🌻 Flexible and fast ZSH plugin manager
MIT License
2.89k stars 125 forks source link

maint: fix global vars creation and all other zsh-sweep reported errors #469

Closed psprint closed 7 months ago

psprint commented 1 year ago

Description

I've run psprint/zsh-sweep on zinit sources and obtained some reports about global var creation, which were true, so I fixed them.

Motivation and Context

My motivation was testing the linter zsh-sweep on some real-world, complex inputs.

How Has This Been Tested?

I've run zi delete --all and restarted zsh.

Types of changes

Checklist:

psprint commented 1 year ago

I've fixed all errors and made all sources pass zsh-sweep linter. Could the linter be adopted by zinit, @vladdoster ? It would nicely gate the new code for errors.

vladdoster commented 1 year ago

@psprint,

Merge conflicts

vladdoster commented 1 year ago

@psprint,

Is this PR still a WIP?