search

zdharma-continuum / zinit

🌻 Flexible and fast ZSH plugin manager
MIT License
2.89k stars 124 forks source link

[bug]: [gh-r] Error: No GitHub release assets found for v7.3.2 #476

Closed hrai closed 1 year ago

hrai commented 1 year ago

What happened?

I have this code in my .zshrc

    zinit ice from"gh-r" as"program" bpick"*.deb"
    zinit light powershell/powershell

I get the error when I know there are release assets.

[gh-r] Error: bpick ice found no release assets. To fix, modify the bpick glob pattern *.deb

[gh-r] Error: No GitHub release assets found for v7.3.2

Steps to reproduce

zinit ice from"gh-r" as"program" bpick"*.deb"
zinit light powershell/powershell

Relevant output

No response

Screenshots and recordings

image

Operating System & Version

OS: linux-gnu | Vendor: ubuntu | Machine: x86_64 | CPU: x86_64 | Processor: x86_64 | Hardware: x86_64

Zsh version

zsh 5.9 (x86_64-ubuntu-linux-gnu)

Terminal emulator

xterm-256color

If using WSL on Windows, which version of WSL

WSL 2

Additional context

No response

Code of Conduct

vladdoster commented 1 year ago

@hrai,

Thanks for reporting this. I'm looking into it.

vladdoster commented 1 year ago

@hrai,

The repository is case-sensitive.

https://github.com/PowerShell/PowerShell

zinit for \
    from'gh-r' \
    lbin'!**/pwsh->pwsh' \
    bpick'*linux-x64*' \
    null \
  @PowerShell/PowerShell
Screenshot 2023-02-16 at 03 10 31
vladdoster commented 1 year ago

The bpick is only needed due to various Linux assets. Additionally, we filter out Linux packages (i.e., deb, rpm).

hrai commented 1 year ago

@vladdoster Currently it's sourcing everything in the folder, is there a way to source only the correct executable?

vladdoster commented 1 year ago

@hrai,

What do you mean sourcing? Please provide a screenshot.

hrai commented 1 year ago

@vladdoster it's this block from your screenshot.

vladdoster commented 1 year ago

@hrai,

Circling back on this issue.

Addressing the concern regarding Zinit sourcing a ton of miscellaneous executables.

I think this is a non-issue. If you are referring to the log output that states Zinit has marked 300+ files as executable, it a a non-issue. If you look at:

la -l $ZPFX

You will see that only those files are ones that get added to your $path.

Additionally, if you have no more issues could we consider the issue resolved and close the issue?

Can this issue be closed?

vladdoster commented 1 year ago

@hrai

@vladdoster it's this block from your screenshot.

Which line exactly?

vladdoster commented 1 year ago

@hrai,

Fixed in #479.

hrai commented 1 year ago

Thanks @vladdoster