[bug]: `zinit creinstall -Q ...` or `-q` is not quiet

PyroDevil commented 1 year ago

What happened?

The documentation states that the -q or -Q parameter for zinit creinstall is quiet, but it prints ==> Installed 1 completion.

This is annoying because I have put this command into the zshrc and thus it gets printed on every new shell.

Sure this can be worked around with a >/dev/null, however, IIRC this happend only after a zinit update, so it might be a regression or unintended change.

Steps to reproduce

Use zinit version v3.11.0
put some completion script into a directory, for instance rustup completions zsh cargo > ".config/zsh/completions/_cargo"
execute zinit creinstall -Q ~/.config/zsh/completions and expect no output.

Relevant output

❯ zinit creinstall ~/.config/zsh/completions
Symlinking completion _cargo to completions directory.
Forgetting commands completed by `_cargo': cargo
==> Installed 1 completion
==> Added 1 completion to $INSTALLED_COMPS array
Initializing completion (compinit)…
❯ zinit creinstall -q ~/.config/zsh/completions
==> Installed 1 completion
❯ zinit creinstall -Q ~/.config/zsh/completions
==> Installed 1 completion

Screenshots and recordings

No response

Operating System & Version

Zsh version

zsh 5.9 (x86_64-pc-linux-gnu)

Terminal emulator

xterm-256color

If using WSL on Windows, which version of WSL

None

Additional context

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

vladdoster commented 1 year ago

@PyroDevil,

Will fix this soon.

In the meantime, to silence it, append the following snippet:

2>&1 > /dev/null

Example:

vladdoster commented 1 year ago

@PyroDevil,

If you have time, please test the patch.

To update your Zinit install with the patch, run:

zinit self-update
cd "$ZINIT[BIN_DIR]"
git pull --all
git checkout fix/creinstall-command
cd -
exec zsh -il

To go back to the main branch of Zinit, run:

cd "$ZINIT[BIN_DIR]"
git checkout main
cd -
exec zsh -il

vladdoster commented 1 year ago

@PyroDevil,

Could you elaborate on why you are running creinstall in your zshrc?

alichtman commented 1 year ago

@vladdoster I tested fix/creinstall-command. I get the following error printed at the top of my terminal when the command is zinit creinstall -Q $ZINIT_HOME/completions:

No such (plugin or snippet): -Q.

and using -q, I get the following error:

No such (plugin or snippet): %HOME/.local/share/zinit/zinit.git/completions.

This line works as expected on main.

Anyways, silencing by piping output to /dev/null works (but is messy).

The reason I'm running creinstall is to get a custom completion I'm adding to be recognized:

rustup completions zsh cargo > "$ZINIT[HOME_DIR]/completions/_cargo"

# Install my custom completions
zinit creinstall -Q $ZINIT_HOME/completions 2>&1 > /dev/null

This comes almost directly from the example in the README:

# Handle completions without loading any plugin; see "clist" command.
# This one is to be ran just once, in interactive session.
zi creinstall %HOME/my_completions

PyroDevil commented 1 year ago

@vladdoster

Sorry for the delay. I tested fix/creinstall creinstall -q or creinstall -Q prints ==> Skipped re-installing 1 completion.

So that is not fixed there.

The reason I use creinstall in .zshrc is the same as @alichtman.

Turiok commented 2 months ago

I have the same problem. I'm using poetry and kubectl completion from OMZP. I have to creinstall to add theses completions.

This is related to #652 . I'm using the kubectl OMZP plugin. But the zsh file generate the completion file in $ZSH_CACHE_DIR/completions so I'm using creinstall

zdharma-continuum / zinit