zdharma-continuum / zinit

🌻 Flexible and fast ZSH plugin manager
MIT License
2.77k stars 123 forks source link

fix: Ignore .yaml and .py files when installing completions #528

Closed pschmitt closed 1 year ago

pschmitt commented 1 year ago

Description

Related Issue(s)

Motivation and Context

Usage examples

zinit as"completions" \
    atclone"pipx install jc; jc --zsh-comp > _jc" \
    atdelete"pipx uninstall jc" \
for kellyjonbrazil/jc

How Has This Been Tested?

Without this, the above would install 13 completions (__init__.py etc) With the patch only _jc gets installed, as expected.

Types of changes

Checklist:

pschmitt commented 1 year ago

urf, the gh-r test fail. The ices zunit pass locally at least.

Edit: fixed in #530

vladdoster commented 1 year ago

BTW, You can remove the python dependency


zinit for \
    from'gh-r' \
    no'compile' \
    lbin \
    atclone'$(pwd)/jc --zsh-comp > _jc' \
    as'completion' \
  @kellyjonbrazil/jc
pschmitt commented 1 year ago

BTW, You can remove the python dependency


zinit for \
    from'gh-r' \
    no'compile' \
    lbin \
    atclone'$(pwd)/jc --zsh-comp > _jc' \
    as'completion' \
  @kellyjonbrazil/jc

Yes that works too, sadly there's no arm64 build available.

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 3.12.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: