feat: themes support +2 new themes, blue and gold

[psprint]

Description

I think that the theming potential behind +zinit-message should be used. All styles like {error}, {warn} (or the new {w} that includes Warning: prefix – cool idea :smile:), {pname} have their corresponding keys in ZINIT hash. I think that exporting the tabular hash data (2 columns with pairs of key/value) to a separate file is a good idea also from code cleanliness perspective.

Related Issue(s)

I'm refreshing an older PR #445, done before the color data has been refactored by @vladdoster ,

Motivation and Context

The +zinit-message function has been created with theming in mind from the start. It only felt that the styles database should first grow a little before another themes would be added. Now it seems complete, so it's a good moment of adding some themes.

The patch is very simple – it only moves the ZINIT+=( … … ) assignment to a separate file share/themes/default.zsh and then is duplicated to blue.zsh and gold.zsh and then the copies are altered to different styling. Nothing can broke…

Usage examples

ZITHEME=gold /bin/zsh
ZITHEME=blue /bin/zsh
ZITHEME=default /bin/zsh

Default theme – no changes:

Plugin installation:

Wrong ice error:

New "Blue" theme:

Plugin installation:

Wrong ice error:

New "Gold" theme:

Plugin installation:

Wrong ice error:

How Has This Been Tested?

Like the Usage examples section.

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] Documentation change
• [x] New feature (non-breaking change which adds functionality)

Checklist:

• [x] All new and existing tests passed.
• [ ] I have added tests to cover my changes.
• [ ] I have updated the documentation accordingly.

[psprint]

@vladdoster @pschmitt @alichtman: ping? are you guys on vacation? ;)

[psprint]

@alichtman: you seem to be the only active maintainer. Could you merge this straightforward, harmless patch?

[alichtman]

I'd ping @vladdoster. I haven't merged any real code to this ever, really. Don't have time / bandwidth to be a "good" maintainer

[psprint]

Ping @vladdoster then. The patch is harmless, could you merge?

[psprint]

@vladdoster: Hi. What holds you before merging this PR?

[vladdoster]

@psprint,

This is cool, but I'd like to see some of the available col-* options removed due to lack of use.

Has someone asked for the ability to theme zinit logging? It seems unnecessary...

---

FYI, I have not been online for last two months for personal reasons. I should be more active in the future.

[psprint]

I've removed the 11 unused entries from themes via this script:

for col in `grep -o col-[[:alnum:]]* share/themes/blue.zsh `; do
if ! \ag ${col##col-}\} zinit*.zsh &>/dev/null; then print missentry $col;
    read -q && \
        if sed -r -i -e "s/[[:space:]]+${col}[[:space:]]+\\\$'[^']*'//g" share/themes/*.zsh
         then
              print replaced
         fi
fi
done

It's output is:

missentry col-quo
yreplaced
missentry col-quos
yreplaced
missentry col-aps
yreplaced
missentry col-tab
yreplaced
missentry col-bapo
yreplaced
missentry col-nst
bmissentry col-term
yreplaced
missentry col-baps
yreplaced
missentry col-nu
nmissentry col-bar
nmissentry col-bcmd
yreplaced
missentry col-txt
yreplaced
missentry col-bspc
missentry col-uname
nmissentry col-uninst
yreplaced
missentry col-failure
yreplaced
missentry col-ndsh
missentry col-uname

I think that the theming is a good idea because:

• it allows for light/dark setups; for example, I'm using white terminal background and blue theme is much more readable,
• no requests for this feature doesn't mean it isn't wanted, it's just that users didn't thought that such a detailed approach to messaging is possible to expect from devs,
• it is a cleanup/refactor of the code at the same time – it moves the tabular data out to separate files,
• `it's very easy change.

[psprint]

@vladdoster: I've did what you requested and all CI checks pass (except for docs, which I cannot generate because no docker), so could you merge?

[psprint]

Why isn't this PR yet merged? Is it because of doubts of usability? If yes, then I tell you that once it's merged, you'll never look back on the old, unseparated (tabular data in zinit.zsh) approach… PLEASE MERGE there isn't anything to dispute about more…

[psprint]

@vladdoster: ping above comment

[psprint]

@vladdoster: Could we please stop playing in a mouse and a cat, and merge this straightforward, harmless and cleanup patch?

[psprint]

@vladdoster: We could easily add support for this neon theme with the pr merged:

https://www.reddit.com/r/zsh/comments/15rj8rq

[psprint]

@vladdoster you seem active today. Why not merge this straightforward, harmless, cleanup patch? What is the reason?