[bug]: zinit update does not pull stable release from GitHub releases

hrai commented 6 months ago

What happened?

zinit from'gh-r' sbin'**/nvim' ver'stable' for neovim/neovim

My neovim version is below

NVIM v0.9.1
Build type: Release
LuaJIT 2.1.0-beta3

When I run zinit update neovim/neovim it doesn't pull the latest release which is v0.9.4

Instead it shows below:

Steps to reproduce

Add zinit from'gh-r' sbin'**/nvim' ver'stable' for neovim/neovim Run zinit update neovim/neovim

Relevant output

No response

Screenshots and recordings

No response

Operating System & Version

Zsh version

zsh 5.9 (x86_64-ubuntu-linux-gnu)

Terminal emulator

Windows Terminal - xterm-256color

If using WSL on Windows, which version of WSL

WSL 2

Additional context

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

vladdoster commented 6 months ago

@hrai,

Interesting... I think this is what is happening.

It is checking for stable, but because stable is a word and not a number, it concludes that it is already up to date.

vladdoster commented 6 months ago

@hrai,

I've been aware of this bug for a while and think your issue will be fixed by addressing update option parsing and now seems like a good time to squash this bug.

Currently, to re-download the stable version (or something like nightly), the flags break it and force the following process:

(){
  setopt local_options interactive_comments
  # Note: both flags are required.... this is the bug :^)
  zinit update \
    --reset \
    --urge \
    neovim/neovim
  # Next, run:
  zinit update \
    --reset \
    neovim/neovim
}

So I think the fix is fixing flag parsing. Stay tuned!

hrai commented 1 month ago

@vladdoster any update on this one?

zdharma-continuum / zinit