zdharma-continuum / zinit

🌻 Flexible and fast ZSH plugin manager
MIT License
3.2k stars 129 forks source link

[bug]: Cannot load zsh-edit #635

Open ittayd opened 10 months ago

ittayd commented 10 months ago

What happened?

zinit light @marlonrichert/zsh-edit gives this error:

(anon):11: command not found: zsh-edit
(anon):unfunction:13: no such hash table element: zsh-edit

This seems to be because the shadowing autoload doesn't behave exactly like autoload. I can see there's still shadowing because zinit report marlonrichert/zsh-edit outputs:

Report for marlonrichert/zsh-edit plugin
----------------------------------------
Source zsh-edit.plugin.zsh (no reporting)
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/bind with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/zsh-edit with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/.edit.execute-cmd with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/.edit.find-replace with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/.edit.insert-word with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/.edit.move-word with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/_edit._show_clipboard with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/.edit.visual-yank with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/zsh-edit with options -U -z
Autoload add-zsh-hook with options -U -z
Autoload zsh-edit-precmd

Completions:
_bind [enabled]
_edit._show_clipboard [enabled]

Note that even if I add a separate autoload -Uz $fdir/zsh-edit in the plugin file, then still functions like .edit.move-word that are expected are not defined.

I think there are two bugs here:

  1. the shadowed autoload is not compatible with the builtin
  2. light mode doesn't turn off shadowing.

Note that this happens also if I take a fresh .zshrc after just zinit installation

Steps to reproduce

see above

Relevant output

No response

Screenshots and recordings

No response

Operating System & Version

OS: linux-gnu | Vendor: ubuntu | Machine: x86_64 | CPU: x86_64 | Processor: x86_64 | Hardware: x86_64

Zsh version

zsh 5.8.1 (x86_64-ubuntu-linux-gnu)

Terminal emulator

xterm-256color

If using WSL on Windows, which version of WSL

None

Additional context

No response

Code of Conduct