Password Gorilla Freezes on Cmd+O

[jondlove]

OS: Mac OSX Snow Leopard (10.6.8) Password Gorilla version: 1.5.3.6

Actions performed:

• Open Password Gorilla
• Select a database, enter the correct password, press OK
• Gorilla displays progress bar
• Gorilla unlocks password database
• Press Cmd+O

What I expect to happen:

• Gorilla displays the "Open Password Database" dialog

What actually happens:

• Gorilla displays the "Open Password Database" dialog with a half-completed "Opening..." progress bar in front of it
• Gorilla freezes

Note:

• Selecting File>Open from the menubar works fine, and performs the expected behaviour

[zdia]

Issue confirmed. Thank you for the feedback.

[rich123]

Repeatable. So far I have found a change which makes cmd+O work properly, but results in File->Open exhibiting the old cmd+O behavior (Freezing). That is not much of an improvement yet.

[rich123]

@rpgsimmaster, do you have the capability to run the source distribution of Password Gorilla? I ask because so far my attempts to roll a Mac distribution bundle have resulted in bundles that do not run on my test VM setup. If you can run the source, I have a modification that appears to work around the issue on my VM, and having some additional test confirmation that it works in your environment would be a good thing.

[jondlove]

@rich123 I am now running from a repo clone. I don't know if a patch has been committed, since the issue still exists with my fork. However, my source distribution appears to be otherwise working.

[rich123]

@rpgsimmaster No, no patch as of yet. But if you will, try this. At about line 644 in the gorilla.tcl file, you will find a line like this:

bind . <$meta-o> {.mbar.file invoke 1}

change it so it reads:

bind . <$meta-o> {after 150 .mbar.file invoke 1}

Then save the file and try various Cmd-O attempts to see if you can still get it to hang. If it does not hang, then this is a workaround. Actually it is a hacky workaround, a true fix involves rewriting the open dialog handling code to avoid use of a Tcl vwait in the middle of the code. But if this works for you, then at least it overcomes the issue until I can get around to that rewrite.

[jondlove]

@rich123 That appears to work, thanks!